receive/store: use Client.String() #7406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Client.String() instead of allocating a new string each time. With 15-20k req/s I have noticed that a lot of time is spent on allocating a new string here. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
fpetkovski
approved these changes
May 31, 2024
yeya24
reviewed
Jun 1, 2024
| return &localClient{ | ||
| StoreClient: c, | ||
| store: store, | ||
| desc: fmt.Sprintf( | ||
| "LabelSets: %v MinTime: %d MaxTime: %d", | ||
| labelpb.PromLabelSetsToString(labelpb.ZLabelSetsToPromLabelSets(store.LabelSet()...)), mint, maxt, |
There was a problem hiding this comment.
I wonder if we have a way to avoid fmt.Sprintf here. I see it performs poorly and show up in CPU profiles
There was a problem hiding this comment.
What are the alternatives?
There was a problem hiding this comment.
Isnt it mitigated by this PR anyhow?
There was a problem hiding this comment.
Yeah, this PR together with caching matchers reduced CPU usage by 10% on every single receiver node in our case
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Client.String() instead of allocating a new string each time. With 15-20k req/s I have noticed that a lot of time is spent on allocating a new string here.