Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use GetParams #363

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Don't use GetParams #363

merged 1 commit into from
Mar 6, 2022

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Mar 6, 2022

Description

Closes: #XXX

Fixes UnmarshalJSON error when getting params from the store

: 9:12PM INF applying upgrade "v2" at height: 58700
Mar 06 21:12:04 Evmos cosmovisor[161022]: 9:12PM INF migrating module claims from version 1 to version 2
Mar 06 21:12:04 Evmos cosmovisor[161022]: panic: UnmarshalJSON cannot decode empty bytes

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@fedekunze fedekunze merged commit 39f0f27 into release/v2.0.x Mar 6, 2022
@fedekunze fedekunze deleted the dev/v2.0.1 branch March 6, 2022 21:31
fedekunze added a commit that referenced this pull request Mar 7, 2022
* release: bump Evmos version to v2 (#351)

* fix changelog

* fix

* swagger

* swagger

* fix

* go mod

* app: upgrade handler for v2 (#352)

* app: set up upgrade handler for v2

* use newer sdk version instructions

* run migrations and set modules versions to 1

* add TODO

* use osmosis style upgrade handlers

* remove upgrade handler for olympus mons

* make note of inflation module change as well

* add store loaders upgrade

* set the params for erc20 module

* set the params for claims

* pass in keeers to upgrade handler

* apply upgrade at specified height

* remove store loaders upgrade

* bump the claims consensus version

* add binaries info to upgrade info

* add new claims params

* add comment

* insert sdk fork and upgrade handler

* update dependencies to v2

* remove old fork

* docs: use `go install` for cosmovisor (#356)

* docs: add `v1.0.0` to cosmovisor install (#357)

* remove old evmos

* go mod tidy

* fix upgrade handler to not replace version map

* docs: cosmovisor v2 upgrade preparation docs (#358)

* docs: fix rpc urls

* docs: v2 upgrade instructions for cosmovisor

* add details for latest v1 release

* release: `v1.1.2` changelog (#359)

* release: v1.1.0 (#324)

* release: v1.1.1 (#346)

* fix conflicts

* conflicts

Co-authored-by: Prajjwol Gautam <not@acyb.org>

* app: upgrade v1.1.2 logic to v2 (#354)

* app: set up upgrade handler for v2

use newer sdk version instructions

run migrations and set modules versions to 1

add TODO

use osmosis style upgrade handlers

remove upgrade handler for olympus mons

make note of inflation module change as well

add store loaders upgrade

set the params for erc20 module

set the params for claims

pass in keeers to upgrade handler

apply upgrade at specified height

remove store loaders upgrade

bump the claims consensus version

add binaries info to upgrade info

add new claims params

add comment

throw upgrade plan at cosmovisor

clean up changes that should be in v2

clean up changes that should be in v2, again

remove extra dependency

* go mod tidy

* add changelog

* Update fork code to use something closer to upgrade module

* Fix improt error

* remove upgrade height check

* log errors

* panic on error instead

* add back height gate

* add missing bracket

* erc20 migrator

* nolint

* claims migration

* add TODO

* rm erc20 upgrade

* don't register migration for claims

* update changelog

Co-authored-by: ValarDragon <dojha12@gmail.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* update fork.go

Co-authored-by: Prajjwol Gautam <not@acyb.org>
Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com>
Co-authored-by: ValarDragon <dojha12@gmail.com>

* upgrade handler

* cleanup

* register erc20 migration

* deps: bump ethermint to v0.11.0 (#360)

* deps: bump ethermint to v0.11.0

* changelog

* bump ethermint

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Prajjwol Gautam <not@acyb.org>
Co-authored-by: ValarDragon <dojha12@gmail.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* Merge pull request from GHSA-5jgq-x857-p8xw

* fix: only enable claims from authorized channels

* changelog

* changelog 2

* fix tests

* rename to authorized

* update forks

* upgrade height

* check for EVM chains

* bonded ration adjustment

* update genesis

* fixes

* swagger

* fix: don't use GetParams (#363)

Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com>
Co-authored-by: Prajjwol Gautam <not@acyb.org>
Co-authored-by: ValarDragon <dojha12@gmail.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants