D3D12 Xbox work continued #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibitijibibo
force-pushed
the
d3d12_xbox
branch
from
4da2339
to
bff2f0c
Compare
flibitijibibo
force-pushed
the
gpu_next
branch
from
8d15a6f
to
95bf26e
Compare
flibitijibibo
force-pushed
the
d3d12_xbox
branch
from
bff2f0c
to
7097ed8
Compare
flibitijibibo
approved these changes
Aug 27, 2024
flibitijibibo
force-pushed
the
gpu_next
branch
2 times, most recently
from
3856fbc
to
7ef675e
Compare
|
We're having trouble with the swapchain resizing, but we're like 99% sure it's an OS bug - let's rebase and get this in, once we file a bug we can just throw a FIXME in an appropriate spot pointing to the dev forums or something. |
|
I agree, I think this is a bug somewhere and not something that will require a redesign. |
… include xbox headers
thatcosmonaut
requested changes
Aug 29, 2024
src/gpu/d3d12/SDL_gpu_d3d12.c
Outdated
| { | ||
| /* NOTE: order matters here! */ | ||
|
|
||
| if (usageFlags & SDL_GPU_TEXTUREUSAGE_SAMPLER_BIT) { | ||
| if (isSwapchainTexture) { | ||
| return D3D12_RESOURCE_STATE_PRESENT; |
There was a problem hiding this comment.
If we're gonna do this, we should probably change the resource barrier in AcquireSwapchainTexture to use TextureSubresourceTransitionFromDefaultUsage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the remaining pieces for #7