Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: Add device feature queries #88

Merged
merged 2 commits into from
Jul 11, 2024
Merged

vulkan: Add device feature queries #88

merged 2 commits into from
Jul 11, 2024

Conversation

TheSpydog
Copy link
Collaborator

Adds feature checks and fallback logic for fillModeNonSolid which is only supported on ~50% of Android devices and multiDrawIndirect which has ~67% support on Android.

flibitijibibo
flibitijibibo reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing, otherwise good

src/gpu/vulkan/SDL_gpu_vulkan.c Outdated Show resolved Hide resolved
@flibitijibibo flibitijibibo merged commit 881a816 into gpu Jul 11, 2024
76 of 78 checks passed
@flibitijibibo flibitijibibo deleted the feature-queries branch July 11, 2024 11:40
flibitijibibo pushed a commit that referenced this pull request Jul 11, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
e9a7600
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 12, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
54e2206
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 13, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
2a1031b
flibitijibibo pushed a commit that referenced this pull request Jul 16, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
6e1b068
flibitijibibo pushed a commit that referenced this pull request Jul 19, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
2f4334a
flibitijibibo pushed a commit that referenced this pull request Jul 30, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
d0cd4b0
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 30, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
02e4ae5
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 1, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
4ab501c
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 1, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
0372281
flibitijibibo pushed a commit that referenced this pull request Aug 2, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
de9c927
flibitijibibo pushed a commit that referenced this pull request Aug 4, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
2c570c7
thatcosmonaut pushed a commit that referenced this pull request Aug 5, 2024
@TheSpydog @thatcosmonaut
vulkan: Add device feature queries (#88)
2317b18
flibitijibibo pushed a commit that referenced this pull request Aug 6, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
68438d5
flibitijibibo pushed a commit that referenced this pull request Aug 9, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
019f89e
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 9, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
4548a17
TheSpydog added a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 17, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (thatcosmonaut#88)
8d61cd1
flibitijibibo pushed a commit that referenced this pull request Aug 23, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
d22efe9
flibitijibibo pushed a commit that referenced this pull request Aug 28, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
843a492
flibitijibibo pushed a commit that referenced this pull request Aug 28, 2024
@TheSpydog @flibitijibibo
vulkan: Add device feature queries (#88)
4668ebf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flibitijibibo flibitijibibo flibitijibibo left review comments

@thatcosmonaut thatcosmonaut thatcosmonaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSpydog @flibitijibibo @thatcosmonaut