Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Opening external player in Windows requires Running as Administrator #460

Closed
3 tasks done
dragonfleas opened this issue Jun 18, 2024 · 3 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@dragonfleas
Copy link

Preflight checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the frequently asked questions for a solution that fixes this problem, without success.
  • I have checked that I'm using the latest stable version of the app.

What app version are you using?

v5.1.4

What operating system version are you using?

Windows

Expected Behavior

I expect the executable to be invoked without the need to run as administrator, as long as I have proper permissions to launch it.

If this is intended behavior, do you think we could add a new note to the setting card in section in

<SettingCard title='Enable External Player' description='Tells Miru to open a custom user-defined video player to play video, instead of using the built-in one.'>
<div class='custom-switch'>
<input type='checkbox' id='player-external-enabled' bind:checked={settings.enableExternal} />
<label for='player-external-enabled'>{settings.enableExternal ? 'On' : 'Off'}</label>
</div>
</SettingCard>

Like Requires running as administrator on Windows

If this is a bug, can you assign this to me? I'd like to fix it myself.

Actual Behavior

Process is not invoked, there are no error messages or indications telling you that as well. Default player is black, content is loading in, but player (in this case mpv) is not launched.

Screenshots

No screenshot needed for this.

@dragonfleas dragonfleas added the bug Something isn't working label Jun 18, 2024
@dragonfleas
Copy link
Author

I'm going to test out using the electron native way of spawning a child_process instead of utilizing node's native spawn function. Could be some strange windows permission discrepancy between the two. I think utilityProcess is a 1:1 with node's spawn API so it should work.

@ThaUnknown
Copy link
Owner

administrator isnt needed for this tho?

@dragonfleas
Copy link
Author

administrator isnt needed for this tho?

This ended up being that I happened to select multiple torrents that's streams didn't complete and on the next launch as administrator it circumstantially finished the download. Disregard this issue, I'll close it. Whoops! lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants