Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: use a router for navigation #470

Closed
3 tasks done
lv01-GreyCat opened this issue Jul 5, 2024 · 3 comments
Closed
3 tasks done

[Feature Request]: use a router for navigation #470

lv01-GreyCat opened this issue Jul 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@lv01-GreyCat
Copy link

Preflight checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the features list for this feature, and I couldn't find it.
  • I have checked that I'm using the latest stable version of the app.

Problem Description

When I'm browsing different pages on Miru; like 'New Releases', 'Popular This Season' or a search query. If I click on an episode, the previous context will be completely lost. I will have to type back the search term and scroll to where I was again for each new anime/episode I want to check out.

Proposed Solution

I am not certain what would be the best design for this but maybe having a back button in the video player (+ escape hotkey, like how you can escape the 'Now Playing' page).
I understand this might be difficult depending on how everything is handled. Hopefully my description has been clear enough.

@lv01-GreyCat lv01-GreyCat added the enhancement New feature or request label Jul 5, 2024
@ThaUnknown
Copy link
Owner

yeah, the go-to solution for this is called a router which manages the paths you navigate to, issue is with the framework I'm using I cannot use a good router because I need to use a very specific compiler to get the torrent tech behind Miru working correctly

@ThaUnknown ThaUnknown changed the title [Feature Request]: Remember the last open page after opening an episode [Feature Request]: use a router for navigation Jul 5, 2024
@lv01-GreyCat
Copy link
Author

It does not sound like an easy fix, that's a shame.
When you say framework, are you talking about Svelte ?
What is it that makes the compiler not allow the usage of a good router if you don't mind me asking ?

@ThaUnknown
Copy link
Owner

if you're curious I currently use Svelte with Webpack[bundler], I'm get to find a good router for normal Svelte, I'd like to use SvelteKit and it's router because it's actually fucking goated, but its Vite[bundler] only

the reason I need webpack is because of module aliasing and resolution, I need a bundler which can build multiple outputs in multiple different ways, for example:

  • it needs to compile ESM to CJS as Electron doesn't support ESM
  • it needs to compile for a custom enviorment which is both a browser and nodejs, that means it can both access the DOM and node.js API's
  • it needs to compile for an environment which only implements some, but not all node.js api's [electron preload]
  • it needs to compile for a normal website
  • it needs to support module aliasing, aka "replace dependency X with dependency Y while compiling"

all in a single config in a single build. Vite can't do this

if you find a good router that can compare to sveltekit link it and I'll look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants