Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rayos.js (Node) #237

Closed
waghanza opened this issue Jun 8, 2018 · 11 comments
Closed

Add rayos.js (Node) #237

waghanza opened this issue Jun 8, 2018 · 11 comments

Comments

@waghanza
Copy link
Collaborator

waghanza commented Jun 8, 2018

Hi @aichholzer,

It could be intersting to add https://github.com/GetRayo/rayo.js to this benchmarking project ?

Regards,

@aichholzer
Copy link
Member

Thank you @waghanza -Will submit a PR.

@waghanza
Copy link
Collaborator Author

waghanza commented Jun 9, 2018

@waghanza waghanza closed this as completed Jun 9, 2018
@aichholzer
Copy link
Member

@waghanza -Interesting, in none of my tests has fastify ever been faster and my results are also usually faster than polka.

@waghanza
Copy link
Collaborator Author

waghanza commented Jun 9, 2018

I think I have been tout enthusiastic. Results are wrong. I'll fix it

@aichholzer
Copy link
Member

⚡️ Looking forward to that.
Thank you.

@waghanza
Copy link
Collaborator Author

waghanza commented Jun 9, 2018

@aichholzer
Copy link
Member

aichholzer commented Jun 9, 2018

⚡️ Yeah, that looks like my sort of results. Looking forward to seeing that merged into the main branch, so I can start using it in my docs as a reference.
Thank you.

@aichholzer
Copy link
Member

aichholzer commented Jun 10, 2018

Hello @waghanza -A couple of questions;

  • Will you be pushing those results into master here anytime soon?
  • Looking at your results and these ones, there are quite some differences. For example router.cr goes from 1st place to 19th place, which does not look right. Also, I don't think any Nodejs framework would be faster than japronto (although I am flattered to see rayo above it 😉)
  • Finally, I don't think this list is ordered quite alright, unless the order is not based on performance.

Looking forward to your thoughts.

@waghanza
Copy link
Collaborator Author

waghanza commented Jun 11, 2018

@aichholzer Could yo re-integrate your code ? (I did not why the disappeared -> mis-merge, or something)

  • I'll release results this week
  • The (actual on master) results are wrong, calculated with a built-in sieger (I'm working on a version to use wrk)
  • The ranking order only take count of req/s (and calculated from a workstation - not ideal)

ℹ️ Removed rayo in #244

@waghanza waghanza reopened this Jun 11, 2018
@aichholzer
Copy link
Member

😢

@waghanza
Copy link
Collaborator Author

I re-enabled Rayo in #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants