-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install / update with Nextcloud #929
Comments
I know there are issues, but so far nobody found out why Nextcloud fails. Why Nextcloud moves SnappyMail around is very weird. You should think that Nextcloud always works the same. |
Ok I understand ! I'll try to reproduce the error and see if I can get some logs somewhere. About the |
Doing some testing, I've found this:
That happened while running my daily config script, at this line: After that, I couldn't find anything within the nextcloud file space (docker volume) that did not belong to So something wrong happened, but without consequences here ? On this test instance, no one has ever logged in since the instance creation. |
I've just done also another test, with a live instance that had 2.25.4, and the upgrade went fine: the whole ting has not been turned into maintenance mode. Seen that on the console:
So it is one of two things:
|
I have the same warning "PHP Warning: foreach() argument must be of type array|object, null given in /usr/share/nginx/html/nextcloud/apps/snappymail/app/snappymail/v/2.25.5/app/libraries/snappymail/upgrade.php on line 239" The system has the correct security settings. But the functionality of snappymail seems to be oke as far ik can see. |
I've also noticed the It's good we are on to something why it fails. |
Hello ! So all my instances were in 2.25.4 yesterday, and I did some cleanup as well not to have 2 Snappymail installations present. So all instance had only one Snappymail install, whether it be under This morning, my daily update process has tried to upgrade from 2.25.4 to 2.25.5, and: Almost half were stuck in maintenance mode, and I had to run a
Then for another bunch (not exactly the same set), Snappymail was again duplicated: the old 2.25.4 under
I hope that this will help to understand what's going on ! |
nextcloud/docker#1633 And i'm not a Nextcloud employee to work this out. |
Got it ! I wasn't aware that this happens also to other apps. It shouldn't be too difficult to add some stuff into my update script to fix that, until Nextcloud fix that in their code. EDIT: I've checked in details the three links, but IMHO none of the three links are similar to what we are facing here. They point to issues with having or not some parts of the Nextcloud install within a docker volume. I've also searched in the Nextcloud github issues and couldn't find something similar. |
First you need to figure out why it installs in If the cause is SnappyMail clearing the Opcache, then i won't remove the opcache trick because then a different issue pops up that is way more severe.
In both cases people report issue but 1 needs restart of server and 2 needs to be fixed by Nextcloud. As the opcache trick works for standalone upgrades. |
Just updated to 2.26.3 on my test server. It hung once again in maitanence mode but note this server is on Nextcloud version 25.0.3. I have been hesitant to update my production server but did it today. It is still on version 24.0.6. It actually never got stuck. So I don't know if the issue is something only with v.25. Can anyone verify this? |
Not sure. As I am getting the error above when trying to update now. Nextcloud Hub 3 (25.0.3) |
@HeyVern correct i fixed #991 and Nextcloud has serious issues regarding version numbers so it fails. |
@the-djmaze thanks! Good news, not only did it install now, but it also didn't trigger the maintenance mode issue I've been getting the last few update cycles. Well done! |
@the-djmaze I also just ran the 2.26.4 on my v.25 server and it didn't lock in maintenance mode this time either! |
Then i know what the bug in Nextcloud is. Now i wonder why |
Hello ! This has just happened again, while upgrading the app from 2.28.0 to 2.28.1
|
I know this is annoying, but without error logs we have no clue why Nextcloud fails. |
I don't know if it is related to the maintenance issue but here it the message recorded in Nextcloud's log:
[PHP] Error: Cannot modify header information - headers already sent by (output started at /var/www/nextcloud/lib/private/legacy/OC_EventSource.php:111) at /var/www/nextcloud/apps/snappymail/app/snappymail/v/2.28.1/include.php#134
GET /core/ajax/update.php?requesttoken=
This was the first time that I ran the update and it actually allowed me to go through the setup from refreshing the page and telling it to continue the install. Previously when this happened, I'd have to edit the config.php file manually for the maintenance mode to trigger the install from the website. I'm on Ubuntu 20.04, NC 25.0.6, and PHP 7.4.3.
June 8, 2023 at 8:48 AM, "the-djmaze" ***@***.***> wrote:
I know this is annoying, but without error logs we have no clue why Nextcloud fails.
—
Reply to this email directly, view it on GitHub #929 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGSHRQ54DRQFSZGT5OKBQTXKHC2BANCNFSM6AAAAAAUVEAE7E .
You are receiving this because you commented.
**Matt Coulter**
**Director of Technology**
***@***.*****
**(o) 706-940-5113 x.8**
|
Is it possible that there is an other app or app's enabled for witch there are no updates available? The effect is the same.
"MichelMallejac" ***@***.***> schreef op 7 juni 2023 om 09:42:
…
Hello !
This has just happened again, while upgrading the app from 2.28.0 to 2.28.1
* NC put itself in maintenance mode
* manually had to do an occ upgrade to get it back online
—
Reply to this email directly, view it on GitHub #929 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ7T2D4P6I6FYN3M2WMXIDTXKAWFNANCNFSM6AAAAAAUVEAE7E .
You are receiving this because you commented.
|
Hello ! I've done little progress here. I've written a few bash lines in order to fix the situation when things go wrong with Snappymail installation (when a version upgrade occurs).
And tested that this morning but it does not work ! So now the question is: where inside Nextcloud is configured the path of Snappymail ? In other words where is it said whether Snappymail should be called in I've searched through the Nextcloud database but couldn't find the information. |
Silly question : since the issue is about Snappymail app location, how stupid whould it be to have a small line of script that would duplicate the current Snappymail into the other folder ? If inside |
I did some tests with my Nextlcoud 25.0.3 and can't reproduce the error.
What i did notice is that Nextcloud gives 0 to no feedback using So i modified Nextcloud code:
I've also modified my install/upgrade/repair code to give more info
Please use these changes to find your problems. |
Describe the bug
Issues with our update process for Snappy.
For all our ocker instances, we have a daily stop / start / update process that:
docker-compose stop
docker exec --user www-data thisOne-nextcloud-1 php occ app:install snappymail
(and all other apps that we use)docker exec --user www-data thisOne-nextcloud-1 php occ app:update snappymail
(and all other apps that we use)docker exec --user www-data thisOne-nextcloud-1 php occ app:enable snappymail
(and all other apps that we use)This morning on some instances - not all ! - Nextcloud wasn't usable, GUI blocked on "need to process Snappy update", so I had to
... php occ upgrade
for these instances, and then it was ok.I can see in the config script log file that it went well until snappymail install command:
So it seems that Nextcloud put itself into maintenance mode just after installing / updating Snappymail.
You mentioned in #910 that SnappyMail can't be installed using cli yet but added this fix be0348b
Please complete the following information:
Also still not sure where the Snappymail app is supposed to be installed in:
apps/
orcustom_apps
?On one instance this morning I had to move the
snappymail
folder fromcustom_apps
toapps
.I've checked on all instances, and some have 2 install:
apps
custom_apps/
Nextcloud is hopefully only aware of the new 2.25.4 and it is this one that is being run when starting it.
It is probably due to some ugly fixing I had to do a few days ago when I was stuck during Error with 25.0.3 upgrade #910
May I simply remove the old 2.25.2 under
apps
?The text was updated successfully, but these errors were encountered: