Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename createAction to createActionCreator and make createAction an alias for it #30

Closed
the-dr-lazy opened this issue Apr 3, 2019 · 0 comments
Closed

Rename createAction to createActionCreator and make createAction an alias for it #30

the-dr-lazy opened this issue Apr 3, 2019 · 0 comments
Assignees
@the-dr-lazy
Labels
enhancement New feature or request
Milestone
v1.4.0

Comments

@the-dr-lazy
Copy link
Owner

the-dr-lazy commented Apr 3, 2019 •
edited
Loading

Personally, I choose more declarative names over shorter. But as said, this is a personalized issue and some other developers prefer shorter names. Also, other similar libraries like redux-actions use createAction name for the action creator factory function! So this made a wrong convention between developers and at least we should adhere to this convention for now.

For the above reasons, I think the best way to cover both styles for now is to use declarative names inside the library.

For this purpose the createAction function should rename to createActionCreator and use createAction as an alias for createActionCreator to not make a break change.
@the-dr-lazy the-dr-lazy self-assigned this Apr 3, 2019
@the-dr-lazy the-dr-lazy added the enhancement New feature or request label Apr 3, 2019
@the-dr-lazy the-dr-lazy added this to the v1.4.0 milestone Apr 3, 2019
@the-dr-lazy the-dr-lazy added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 3, 2019
@the-dr-lazy the-dr-lazy mentioned this issue Apr 3, 2019
Closed
the-dr-lazy pushed a commit that referenced this issue Apr 4, 2019
feat: make createAction as an alias for createActionCreator
2ccf0c7 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 4, 2019
feat: rename createAction to createActionCreator
87a2cf9 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 4, 2019
refactor: make createAction as an alias for createActionCreator
352d0bb 
closes #30
@the-dr-lazy the-dr-lazy mentioned this issue Apr 4, 2019
Merged
the-dr-lazy pushed a commit that referenced this issue Apr 4, 2019
@the-dr-lazy
feat: rename createAction to createActionCreator
a57e0b3 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 4, 2019
@the-dr-lazy
refactor: make createAction as an alias for createActionCreator
313ae72 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 5, 2019
feat: rename createAction to createActionCreator
028c1c3 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 5, 2019
refactor: make createAction as an alias for createActionCreator
0ca44cd 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 5, 2019
feat: rename createAction to createActionCreator
0ac3920 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 5, 2019
refactor: make createAction as an alias for createActionCreator
975591c 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 21, 2019
@the-dr-lazy
feat: rename createAction to createActionCreator
a855997 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 21, 2019
@the-dr-lazy
refactor: make createAction as an alias for createActionCreator
734f2ad 
closes #30
the-dr-lazy pushed a commit that referenced this issue Apr 21, 2019
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
c9c6cfe 
# [1.4.0](v1.3.1...v1.4.0) (2019-04-21)

### Bug Fixes

* make rxjs/operators in UMD bundle an external dependency ([cf94ab7](cf94ab7)), closes [#41](#41)

### Features

* rename createAction to createActionCreator ([a855997](a855997)), closes [#30](#30)
@the-dr-lazy the-dr-lazy removed good first issue Good for newcomers help wanted Extra attention is needed labels Apr 30, 2019
@the-dr-lazy the-dr-lazy mentioned this issue Jun 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@the-dr-lazy the-dr-lazy

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@the-dr-lazy