Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-editable media #2

Closed
2 of 4 tasks
forresto opened this issue Dec 9, 2015 · 4 comments
Closed
2 of 4 tasks

non-editable media #2

forresto opened this issue Dec 9, 2015 · 4 comments

Comments

@forresto
Copy link
Contributor

forresto commented Dec 9, 2015

with tooltip to trigger meta modal, to make it work as it does now

  • figure out how to express in schema
  • suppress editing
  • suppress click / text selection / drag over etc
  • event for media clicked

Related PM discussion: https://discuss.prosemirror.net/t/prosemirror-ready-for-widgets-islands-of-non-editable-content/12/8?u=forresto

@forresto forresto modified the milestone: 2015-12-14 - PR Dec 9, 2015
forresto added a commit that referenced this issue Dec 10, 2015
forresto added a commit that referenced this issue Dec 14, 2015
@forresto
Copy link
Contributor Author

Hmm... I think non-editable blocks are going to need to be implemented in PM,,, the schema to add contenteditable="false" was easy enough, and the cursor doesn't show up, but you can still type in those blocks. 🐉

@forresto
Copy link
Contributor Author

So I need to do one of:

  1. wait til PM supports non-editable blocks - https://discuss.prosemirror.net/t/prosemirror-ready-for-widgets-islands-of-non-editable-content/12/8?u=forresto
  2. wait til PM supports "locked" nodes - https://github.com/ProseMirror/prosemirror/blob/master/Plan.md#implement-locked-nodes
  3. accept freely editable <article> and <figure> html (not compatible with current api / ds)

or

Explore splitting editor between text / media, so text blocks are grouped and editable. A bit of a regression to v1, but potentially more solid than the One Content Editable ideal we've been bashing our heads against all year.

@forresto
Copy link
Contributor Author

Or put PM work on ice until those features are in, 1-4 weeks?

@forresto
Copy link
Contributor Author

forresto commented Jan 7, 2016

new path

@forresto forresto closed this as completed Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant