Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_lang: ptBR #119

Merged
merged 3 commits into from
Jan 8, 2023
Merged

add_lang: ptBR #119

merged 3 commits into from
Jan 8, 2023

Conversation

mahzze
Copy link
Contributor

@mahzze mahzze commented Jan 7, 2023

No description provided.

@mahzze mahzze requested a review from a team as a code owner January 7, 2023 00:12
@mahzze
Copy link
Contributor Author

mahzze commented Jan 7, 2023

I don't come from the EFT community, so, for the terms I was not completely sure about how I should translate (like "barter", which I was not sure if I should use "troca" or "contrabando", went with the former), I used the french and english translations to get an idea of what terms I should translate to.

Copy link
Member

@Razzmatazzz Razzmatazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing a pt-BR translation! Just a couple notes regarding the kinda weird "command" namespace.

translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
translations/pt.json Outdated Show resolved Hide resolved
@mahzze
Copy link
Contributor Author

mahzze commented Jan 7, 2023

I think I got it.
So now i just have to: make the commands more succint and easy to write, take out spaces and uppercases. I'll do it, will also take out the ' ~ ' from some commands to make it easier for the user.
Will commit again in maybe one hour or two

Copy link
Member

@Razzmatazzz Razzmatazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks for the contribution!

@Razzmatazzz
Copy link
Member

.deploy

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: 3ad039e2e17a3cc51d742e59581ba51962bc1b81

@github-actions github-actions bot temporarily deployed to production January 8, 2023 23:43 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

Deployment Results ✅

Razzmatazzz successfully deployed branch 3ad039e2e17a3cc51d742e59581ba51962bc1b81 to production

@Razzmatazzz Razzmatazzz merged commit e059ba1 into the-hideout:main Jan 8, 2023
@Shebuka
Copy link
Contributor

Shebuka commented Jan 26, 2023

Hey @mahzze, nice work with the translation! 👍

It will be great if you can help us with the translation 🌐 of the website tarkov.dev too the-hideout/tarkov-dev#175. The easiest way is to join our translation manager with this link https://poeditor.com/join/project/YA8ZrCsxTi or create a PR to add a translation file in this folder https://github.com/the-hideout/tarkov-dev/blob/main/src/translations/ as you've done here 😁

@mahzze
Copy link
Contributor Author

mahzze commented Jan 29, 2023

Ok, I can do it
I'll do it from github, cause I've got no idea of how to use the poeditor, nor did I see a pt_BR translation section which I could tweak
PS: Also, if it shows that I entered the english translation, I entered looking for a way to fork it (just like one would do here), but didn't find any

@Shebuka
Copy link
Contributor

Shebuka commented Jan 29, 2023

@mahzze Apparently I didn't save the setting that new contributors can add new languages 😅 Now you should be able to see a + button with add language.
In POEditor it's much easier to navigate between terms to translate, filter by untranslated, search terms and more importantly, set a reference language from which to translate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants