Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% PT_BR Translations 🇧🇷 #536

Closed
wants to merge 790 commits into from
Closed

100% PT_BR Translations 🇧🇷 #536

wants to merge 790 commits into from

Conversation

Rafael-Deiro
Copy link
Contributor

100% Translations for PT_BR 🇧🇷

Updates translation.json for Brazilian Portuguese to 100%

Description 🗒️

Fixes some translations and adds the missing ones.
Translations made and exported from POEditor.

Related: #175

Expand for Help

By submitting this pull request, you agree to our code of conduct

@Rafael-Deiro Rafael-Deiro requested a review from a team as a code owner June 13, 2023 02:11
@Rafael-Deiro Rafael-Deiro mentioned this pull request Jun 13, 2023
Open
@Shebuka
Copy link
Contributor

Shebuka commented Jun 13, 2023

Great work on the translation! Thx!

Before we can merge we need to fix a couple of things:

  • first is that I've exported new terms that need to be translated (in New translation terms #537 and also added them to POEditor), sorry to give you more work on that 😅;
  • second is that when exporting from POEditor it's not straightforward: we need first to export tags separately for our 4 translation namespaces and then run i18next-parser to restore the order of the original translation file (POEditor doesn't allow us to sort existing terms... 😩). I normally do this myself but you can give it a try if you want, the config file for i18next-parser is in the root.

Shebuka
Shebuka requested changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@Shebuka Shebuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split translation file in 4 namespaces as mentioned above

@Rafael-Deiro
Copy link
Contributor Author

Great! I'll translate the new strings and run the parser with the namespaces. Thanks

@Shebuka
Copy link
Contributor

Shebuka commented Jun 13, 2023 •
edited
Loading

Also, take a look here: link
I think there are plurals to be fixed, note that we have 4 plural term variants for each term with postfixes indicating how they will be used (like _one or _many) for second/meters/days

Razzmatazzz and others added 24 commits October 21, 2023 15:16
@Razzmatazzz
link locks to map locations
9345cbd
@Razzmatazzz
player marker position in marker options
439e921
@Razzmatazzz
Merge pull request the-hideout#683 from the-hideout/more-map-markers
1bb7a89 
Add more map markers
@Razzmatazzz
tweak map links
9e87da9
@dependabot
Bump actions/checkout from 4.1.0 to 4.1.1
ac80fcc 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump react-i18next from 13.2.2 to 13.3.1
a2b5ef2 
Bumps [react-i18next](https://github.com/i18next/react-i18next) from 13.2.2 to 13.3.1.
- [Changelog](https://github.com/i18next/react-i18next/blob/master/CHANGELOG.md)
- [Commits](i18next/react-i18next@v13.2.2...v13.3.1)

---
updated-dependencies:
- dependency-name: react-i18next
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump react-cookie-consent from 8.0.1 to 9.0.0
830f85f 
Bumps [react-cookie-consent](https://github.com/Mastermindzh/react-cookie-consent) from 8.0.1 to 9.0.0.
- [Release notes](https://github.com/Mastermindzh/react-cookie-consent/releases)
- [Changelog](https://github.com/Mastermindzh/react-cookie-consent/blob/master/CHANGELOG.md)
- [Commits](Mastermindzh/react-cookie-consent@8.0.1...9.0.0)

---
updated-dependencies:
- dependency-name: react-cookie-consent
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump react-router-dom from 6.16.0 to 6.17.0
8b55007 
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.16.0 to 6.17.0.
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@6.17.0/packages/react-router-dom)

---
updated-dependencies:
- dependency-name: react-router-dom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump react-zoom-pan-pinch from 3.1.0 to 3.2.0
079e90c 
Bumps [react-zoom-pan-pinch](https://github.com/prc5/react-zoom-pan-pinch) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/prc5/react-zoom-pan-pinch/releases)
- [Changelog](https://github.com/BetterTyped/react-zoom-pan-pinch/blob/master/CHANGELOG.md)
- [Commits](BetterTyped/react-zoom-pan-pinch@v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: react-zoom-pan-pinch
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump dayjs from 1.11.9 to 1.11.10
daa84dd 
Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.11.9 to 1.11.10.
- [Release notes](https://github.com/iamkun/dayjs/releases)
- [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md)
- [Commits](iamkun/dayjs@v1.11.9...v1.11.10)

---
updated-dependencies:
- dependency-name: dayjs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@the-hideout-combine-prs
Merge dependabot/npm_and_yarn/dayjs-1.11.10 into combined-prs-branch
47746a1
@the-hideout-combine-prs
Merge dependabot/npm_and_yarn/react-zoom-pan-pinch-3.2.0 into combine…
46a36ec 
…d-prs-branch
@the-hideout-combine-prs
Merge dependabot/npm_and_yarn/react-router-dom-6.17.0 into combined-p…
d045ce2 
…rs-branch
@the-hideout-combine-prs
Merge dependabot/npm_and_yarn/react-cookie-consent-9.0.0 into combine…
732cbea 
…d-prs-branch
@the-hideout-combine-prs
Merge dependabot/npm_and_yarn/react-i18next-13.3.1 into combined-prs-…
5631940 
…branch
@the-hideout-combine-prs
Merge dependabot/github_actions/actions/checkout-4.1.1 into combined-…
578245b 
…prs-branch
@Shebuka
ImageOptim pass on bosses images
670aa06
@Shebuka
Recreated Kaban icon
cd66eaa
@Shebuka
Merge pull request the-hideout#712 from the-hideout/tweak-map-links
eee0e47 
tweak map links
@Shebuka
Merge branch 'main' into combined-prs-branch
2798db1
@Shebuka
Merge pull request the-hideout#719 from the-hideout/combined-prs-branch
24481ff 
Combined PRs
@Shebuka
Merge branch 'main' into feature/update_bosses_images
d33d8b8
@Shebuka
Merge pull request the-hideout#720 from the-hideout/feature/update_bo…
649ea4b 
…sses_images

Update bosses images
@Razzmatazzz
svg + tile selection
40ba6aa
GrantBirki and others added 28 commits January 7, 2024 19:26
@GrantBirki
Merge branch 'main' into patch-1
179fd9c
@GrantBirki
Merge branch 'main' into patch-4
0cc2e3e
@GrantBirki
Merge branch 'main' into patch-3
0397eb5
@GrantBirki
Merge branch 'main' into patch-2
3baecda
@GrantBirki
Merge pull request the-hideout#805 from Faalagorn/patch-1
03112d7 
Update polish maps.json
@GrantBirki
Merge branch 'main' into patch-4
c3a4779
@GrantBirki
Merge pull request the-hideout#811 from Faalagorn/patch-4
e320636 
Polish: fix an error in translation
@GrantBirki
Merge branch 'main' into patch-3
6d4f7ef
@GrantBirki
Merge branch 'main' into patch-2
5f5bf2a
@GrantBirki
Merge pull request the-hideout#809 from Faalagorn/patch-3
6ba4c89 
Shorten Polish translation of "All" string a little
@GrantBirki
Merge branch 'main' into patch-2
cd2d983
@GrantBirki
Merge pull request the-hideout#806 from Faalagorn/patch-2
6ded961 
Update polish translation.json
@GrantBirki
Merge branch 'main' into feature/add_kollontay
e3dfb30
@Shebuka
Add popup for lootable items
0451413
@Shebuka
Open links of the map items in the new tab
894449b
@Shebuka
Better var name
db02859
@Shebuka
Use tMaps function for map related translations
695afa3
@Shebuka
Fixed switch related translations
b965b54
@Shebuka
Translation fixes
f926533
@Shebuka
Updated translation files
98d8cc7
@Shebuka
Added log of missing keys
9854b1e
@Shebuka
Fix a translation in ru
aa82667
@Shebuka
Added new keys for interactive map translation
b6c192c
@Shebuka
Removed unused categories;
9b41146 
Replaced interactive with usable as category to avoid confusion
@Shebuka
Updates to Street 2D/3D maps for expansion
c25db8b
@Shebuka
Merge pull request the-hideout#813 from the-hideout/feature/add_kollo…
399c7b9 
…ntay

Add Kollontay and map fixes
@Shebuka
Fixed order of keys
cf0270d
@Shebuka
Added dedicated namespaces
4303dc9
@Shebuka
Copy link
Contributor

Shebuka commented Jan 8, 2024

Seems like the merge to the authors' fork to solve conflicts did not do so well... I've recreated the PR on main fork #814

@Shebuka Shebuka closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shebuka Shebuka Shebuka requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rafael-Deiro @Shebuka @Razzmatazzz @GrantBirki @thaddeus @Faalagorn