-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update boss.json #540
Update boss.json #540
Conversation
Edited Big Pipe and Birdeye Desc, Added MapSpawnChance to all bosses that was missing this function. Chance Number my be off some trying to go from WIKI knowledge of boss spawn chance
related: #539 |
@sinphoenix Thanks for the fresh PR! Is the old one still needed? If not would you be able to close it out? Thanks! |
.deploy to development |
Deployment Triggered 🚀GrantBirki, started a branch deployment to development You can watch the progress here 🔗
|
Deployment Results ✅GrantBirki successfully deployed branch Show Results |
i closed the old one. Hope everything is right in the file |
"chance": 40, | ||
"map": "Interchange" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right? Wiki says 30% Interchange and 5% Streets 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another note is that looking at the API it should be a float value from 0 to 1.
We get the descriptions from this JSON file and generally don't use the other attributes. We get boss spawn chances from the Tarkov Changes, so it's more up to date than whatever the wiki says. spawnChanceOverride is a special case that's really only used for raiders on Labs and Rogues on Lighthouse. While they have a certain chance to spawn in each of their spawn locations on those maps, they will for sure spawn somewhere so their spawn chance is 1. Adding spawnChanceOverride for the other bosses on other maps is not ideal because then we'd have to manually update it rather than just letting it update automatically via the API. |
Closing this PR due to no further activity. spawnChanceOverride should not be added to these bosses because it overrides the spawn chance from the game. It's only used on Labs and Lighthouse where Raiders and Rogues always spawn, but none of their individual spawn points are 100%. |
Edited Big Pipe and Birdeye Desc, Added MapSpawnChance to all bosses that was missing this function.
Chance Number my be off some trying to go from WIKI knowledge of boss spawn chance
Fixed on Big Pipe and Birdeye with added MapSpawnChance
Description 🗒️:
Made changes from other PR i made that fixed MapSpawnChances and fixed Big Pipes Desc. The chance may be off since i do know the format the system is using for chance it self or if that part is pulled from API. Trying to get a better understand of the system here so i can be more of an asset.
Expand for Help