Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boss.json #540

Closed
wants to merge 4 commits into from
Closed

Update boss.json #540

wants to merge 4 commits into from

Conversation

sinphoenix
Copy link

@sinphoenix sinphoenix commented Jun 14, 2023

Edited Big Pipe and Birdeye Desc, Added MapSpawnChance to all bosses that was missing this function.

Chance Number my be off some trying to go from WIKI knowledge of boss spawn chance

Fixed on Big Pipe and Birdeye with added MapSpawnChance

Description 🗒️:

Made changes from other PR i made that fixed MapSpawnChances and fixed Big Pipes Desc. The chance may be off since i do know the format the system is using for chance it self or if that part is pulled from API. Trying to get a better understand of the system here so i can be more of an asset.

Expand for Help

By submitting this pull request, you agree to our code of conduct

Edited Big Pipe and Birdeye Desc, Added MapSpawnChance to all bosses that was missing this function.  

Chance Number my be off some trying to go from WIKI knowledge of boss spawn chance
@sinphoenix sinphoenix requested a review from a team as a code owner June 14, 2023 02:55
@GrantBirki
Copy link
Member

related: #539

@GrantBirki
Copy link
Member

GrantBirki commented Jun 14, 2023

@sinphoenix Thanks for the fresh PR! Is the old one still needed? If not would you be able to close it out? Thanks!

src/data/boss.json Outdated Show resolved Hide resolved
src/data/boss.json Outdated Show resolved Hide resolved
@GrantBirki
Copy link
Member

.deploy to development

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

GrantBirki, started a branch deployment to development

You can watch the progress here 🔗

Branch: 1b8e2d3ed61cf502977a20ec64ea24c0c0f12056

@github-actions github-actions bot temporarily deployed to development June 14, 2023 03:31 Inactive
@GrantBirki GrantBirki added the data Changes related to files that contain data label Jun 14, 2023
@github-actions
Copy link
Contributor

Deployment Results ✅

GrantBirki successfully deployed branch 1b8e2d3ed61cf502977a20ec64ea24c0c0f12056 to development

Show Results

https://1c30b492.tarkov-dev.pages.dev

@sinphoenix
Copy link
Author

i closed the old one. Hope everything is right in the file

Comment on lines +360 to +361
"chance": 40,
"map": "Interchange"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? Wiki says 30% Interchange and 5% Streets 🤔

Copy link
Contributor

@Shebuka Shebuka Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another note is that looking at the API it should be a float value from 0 to 1.

@Razzmatazzz
Copy link
Member

We get the descriptions from this JSON file and generally don't use the other attributes. We get boss spawn chances from the Tarkov Changes, so it's more up to date than whatever the wiki says.

spawnChanceOverride is a special case that's really only used for raiders on Labs and Rogues on Lighthouse. While they have a certain chance to spawn in each of their spawn locations on those maps, they will for sure spawn somewhere so their spawn chance is 1.

Adding spawnChanceOverride for the other bosses on other maps is not ideal because then we'd have to manually update it rather than just letting it update automatically via the API.

@Razzmatazzz
Copy link
Member

Closing this PR due to no further activity. spawnChanceOverride should not be added to these bosses because it overrides the spawn chance from the game. It's only used on Labs and Lighthouse where Raiders and Rogues always spawn, but none of their individual spawn points are 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Changes related to files that contain data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants