Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready to merge] Reproducible environments restructure #575

Closed
wants to merge 219 commits into from
Closed

[Ready to merge] Reproducible environments restructure #575

wants to merge 219 commits into from

Conversation

masonlr
Copy link
Collaborator

@masonlr masonlr commented May 28, 2019

Summary

Implements #468

List of changes proposed in this PR (pull-request)

  • Move content into sections (rather than single file)

What should a reviewer concentrate their feedback on?

  • Whether the table of contents is correct
  • Whether the content has been divided into appropriate sections

Acknowledging contributors

rosiehigman and others added 28 commits May 28, 2019 09:25
and defined data to encompass all digital objects, as before it was referring to 'data and sotware' only.
@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for the-turing-way ready!

Built with commit 6b882b3

https://deploy-preview-575--the-turing-way.netlify.com

@masonlr masonlr mentioned this pull request May 28, 2019
20 tasks
@rainsworth
Copy link
Collaborator

Thanks @masonlr! This appears to have merge conflicts - are you able to resolve?

@masonlr
Copy link
Collaborator Author

masonlr commented Jun 1, 2019

@rainsworth this was a bit of a complex merge but I'm 90% sure I haven't clobbered anything in the reproducible environments section. Fingers crossed! 🤞 (Let me know if you detect any breaks and I can help with the reverts.)

@masonlr
Copy link
Collaborator Author

masonlr commented Jun 1, 2019

I think the mechanics of this merge are too complicated now – I've created a new PR #639 that should be a bit simpler to digest. There was work going on both upstream and downstream of me (on a fork of my repo).

@masonlr masonlr closed this Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book-dash-ldn2019 Issues related to contributions made during the London Book Dash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet