Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Review] Restructure to standalone sections #639

Merged
merged 12 commits into from
Jun 4, 2019
Merged

[Ready for Review] Restructure to standalone sections #639

merged 12 commits into from
Jun 4, 2019

Conversation

masonlr
Copy link
Collaborator

@masonlr masonlr commented Jun 1, 2019

Summary

This is a re-work of PR #575. The parent issue is #468.

List of changes proposed in this PR (pull-request)

  • Move content into sections (rather than single file)

What should a reviewer concentrate their feedback on?

  • Whether the table of contents is correct
  • Whether the content has been divided into appropriate sections

Acknowledging contributors

  • All contributors to this pull request are already named in the table of contributors in the README file.

@masonlr masonlr requested a review from rainsworth June 1, 2019 11:37
@netlify
Copy link

netlify bot commented Jun 1, 2019

Deploy preview for the-turing-way ready!

Built with commit 764bdef

https://deploy-preview-639--the-turing-way.netlify.com

@masonlr
Copy link
Collaborator Author

masonlr commented Jun 1, 2019

Note, this PR incorporates the edits made to book/content/reproducible_environments/* by @alexmorley in be9627a

@masonlr masonlr changed the title feat: Restructure to standalone sections [Ready for Review] Restructure to standalone sections Jun 1, 2019
@masonlr
Copy link
Collaborator Author

masonlr commented Jun 1, 2019

We've lost the figures in the binder section. Will take a look at that now.

@masonlr
Copy link
Collaborator Author

masonlr commented Jun 1, 2019

Moved the images to within the content dir as per #375 discussion.

@rainsworth
Copy link
Collaborator

Thank you @masonlr! 👏 I'm going to run through the other PRs to make sure that there isn't any overlap in restructuring currently before reviewing this one.

@masonlr masonlr mentioned this pull request Jun 3, 2019
3 tasks
@kkmann
Copy link
Collaborator

kkmann commented Jun 3, 2019

yipeeeeh! can be merged, right?

@masonlr
Copy link
Collaborator Author

masonlr commented Jun 3, 2019

Up to @rainsworth now.

@rainsworth
Copy link
Collaborator

rainsworth commented Jun 4, 2019

Thanks @masonlr and @kkmann! I just had a few minor comments on typos in the added Singularity content. I will go ahead and approve this because the chapter looks great, and you can merge it in once you've fixed them.

Can I just ask that you please put each new sentence on a new line in the Singularity section? (I know the rest of the chapter doesn't follow this style guideline either, but ignore that for now) - there are just some sentences that are split over several lines in the Singularity section so it would make reviewing easier going forward.

Thank you so much for your contributions to this chapter! 👏

masonlr and others added 4 commits June 4, 2019 20:58
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
masonlr and others added 6 commits June 4, 2019 20:58
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
@masonlr
Copy link
Collaborator Author

masonlr commented Jun 4, 2019

Can I just ask that you please put each new sentence on a new line in the Singularity section?

@rainsworth I've just run this through prettier.io as per #630. Hope that's okay.

@masonlr masonlr merged commit fb2e60d into the-turing-way:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants