-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for Review] Restructure to standalone sections #639
[Ready for Review] Restructure to standalone sections #639
Conversation
Deploy preview for the-turing-way ready! Built with commit 764bdef |
Note, this PR incorporates the edits made to |
We've lost the figures in the binder section. Will take a look at that now. |
Moved the images to within the |
Thank you @masonlr! 👏 I'm going to run through the other PRs to make sure that there isn't any overlap in restructuring currently before reviewing this one. |
yipeeeeh! can be merged, right? |
Up to @rainsworth now. |
Thanks @masonlr and @kkmann! I just had a few minor comments on typos in the added Singularity content. I will go ahead and approve this because the chapter looks great, and you can merge it in once you've fixed them. Can I just ask that you please put each new sentence on a new line in the Singularity section? (I know the rest of the chapter doesn't follow this style guideline either, but ignore that for now) - there are just some sentences that are split over several lines in the Singularity section so it would make reviewing easier going forward. Thank you so much for your contributions to this chapter! 👏 |
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
Co-Authored-By: Dr. Rachael Ainsworth <rainsworth@users.noreply.github.com>
@rainsworth I've just run this through prettier.io as per #630. Hope that's okay. |
Summary
This is a re-work of PR #575. The parent issue is #468.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors