Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support for HHKB ANSI and JP. Requires separate subdirectories. #71

Merged
merged 1 commit into from
May 12, 2020
Merged

Add VIA support for HHKB ANSI and JP. Requires separate subdirectories. #71

merged 1 commit into from
May 12, 2020

Conversation

diegomsong
Copy link
Contributor

@diegomsong diegomsong commented Mar 27, 2020 •
edited
Loading

Description

Add VIA support for the HHKB Pro 2 (ANSI) with Hasu controller (USB/BT) and HHKB Pro JP with Hasu controller. Tested successfully on my HHKB Pro 2 (ANSI). @bakingpy tested successfully on his HHKB Pro JP.

Submitted PR to qmk_firmware:master for splitting of keyboards/hhkb to keyboards/hhkb/ansi and keyboards/hhkb/jp

Types of Changes

  • Adding a keyboard to VIA
  • Changing a keyboard already in VIA
  • Bug fix
  • Documentation

Checklist

  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • The QMK firmware can be built using QMK master repo.

@diegomsong diegomsong changed the title Add VIA support for HHKB ANSI and JP. Requires separate subfolders fo… Add VIA support for HHKB ANSI and JP. Requires separate subdirectories. Mar 27, 2020
@diegomsong diegomsong mentioned this pull request Mar 27, 2020
Merged
13 tasks
@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Apr 4, 2020
@diegomsong
Copy link
Contributor Author

diegomsong commented May 11, 2020 •
edited
Loading

qmk/qmk_firmware#8582

@Wilba6582
update: PR over at qmk got merged to the upcoming Q2 QMK branch. 🎉 🙌

@wilba wilba merged commit 949fee9 into the-via:master May 12, 2020
@hofstee hofstee mentioned this pull request Jun 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegomsong @wilba