Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide home carousel 隐藏首页轮播图 #4852

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Liumingxun
Copy link
Contributor

About this PR:

  • Add switch for hide carousel
  • Fix type error
    In this code (generatedOptions/categoryElements) that's value may be null, which causes the categoryElements.map() to throw a "TypeError: Cannot read properties of null (reading 'map')" error.

Before:
image

After:
image

@the1812
Copy link
Owner

the1812 commented Aug 10, 2024

编译产物不需要提交哦 (registry/dist/components/style/simplify/home.js)

@Liumingxun
Copy link
Contributor Author

@the1812 已经重置到未修改状态了😄

@the1812 the1812 merged commit 96dfda1 into the1812:preview-features Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants