-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with portals #19
Comments
This is a hard problem and it is impossible to solve it using the current logic, cos current logic is about making some boundaries you could not escape, but you do. How this can be made:
Sounds doable, should be doable. But devil, usually, is hidden in realization details. |
So - portals are working now - https://codesandbox.io/s/w2l1q3m5w7 If you want to manage portaled content as a part of Lock - you have to use scattered trap. Just place another FocusLock inside a portal and assign the same focus group. <FocusLock group="focus1">
<h2>Start editing to see some magic happen {"\u2728"}</h2>
<button>I'm jailed</button>
<button>And I'm too...</button>
{createPortal(
<div>portal
<FocusLock group="focus1">
<button>I'm in portal 1</button>
<button>I'm in portal 2</button>
<button>I'm in portal 3</button>
</FocusLock>
</div>,
document.getElementById("portal-root")
)}
</FocusLock> |
How to reproduce?
Just render portal inside FocusTrap (example)
Why it's matter?
Dropdown menus usually render in portals. And it would be impossible to put focus on them to handle keydowns for example.
I don't know if it is possible to solve this issue
The text was updated successfully, but these errors were encountered: