-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laps-picking function improvements #376
Conversation
I'll try to review this soon. Ignore CI failures again, that problem should be fixed for new PRs though, I hope. |
I forgot one thing, all the docstrings for deprecated functions should get a |
I replaced all |
The The doc build failure seems to occur because the |
I was actually going to ask if you would like me to add tests anyways. I will write some in the next few days. |
0bed205
to
51e9b5d
Compare
Changed implementation of Modelled some tests after the existing test cases. Please let me know if you want them done another way. |
Test failures are because of your changes (except documentation build). |
8788053
to
de8a4ae
Compare
Linting problem outside of this PR |
Looks good now. Do you have any further changes or remarks, or are you happy with everything? |
No more changes from me. Really appreciate your patience with this PR. |
This took longer than I thought, yes. But that's just the way it ends up being sometimes. If you feel like I could have given better feedback on the way, please let me know. Like just about everything else on this project, reviewing PRs is something I learn as I go. Therefore, feel free to criticize and I'll try to improve in the future. |
Reference: #370
Additionally implemented
any
andnone
for thehow
argument ofpick_track_status
.