Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lap times distribution example #377

Merged

Conversation

Casper-Guo
Copy link
Contributor

Makes the following plot:
distribution

The script is broken if timple support is enabled. No idea why that's the case.

@Casper-Guo Casper-Guo force-pushed the laptimes-distribution-example branch from 59adccf to 868440d Compare May 13, 2023 20:08
@Casper-Guo
Copy link
Contributor Author

This one still won't work with timedelta. Seaborn refuses to recognize it as a numeric column. Will try to look more into that.

@theOehrly
Copy link
Owner

This one still won't work with timedelta. Seaborn refuses to recognize it as a numeric column. Will try to look more into that.

That looks like a more complicated problem to solve. I'm not going to add support for patching Seaborn as well to Timple 😅

I guess there are two options, either use Matplotlib directly or just convert to numeric seconds in Seaborn. I'm fine with either one. We don't need to make this more complicated than necessary.

@Casper-Guo
Copy link
Contributor Author

I will stay with Seaborn since the swarm plot is not available in Matplotlib and I don't think only doing the violin plot adds much to the slate of existing examples. Plotting both the distribution and the individual observations is also common in community visualizations.

I've cleaned up the plot a bit and I am open to hear any feedback you have:
distribution

I didn't know where to find the rendered docs. I will fix the appearance of all my example PRs and request review again.

@Casper-Guo Casper-Guo marked this pull request as draft May 17, 2023 00:33
@Casper-Guo Casper-Guo force-pushed the laptimes-distribution-example branch 2 times, most recently from eee6e63 to b68543f Compare May 18, 2023 01:00
@Casper-Guo Casper-Guo marked this pull request as ready for review May 18, 2023 01:10
@Casper-Guo Casper-Guo force-pushed the laptimes-distribution-example branch from b68543f to ea67f80 Compare May 18, 2023 01:20
@Casper-Guo
Copy link
Contributor Author

Reformatted according to your comments on the other PRs. Ready for review

@theOehrly
Copy link
Owner

Everything looks great now. I really like this plot 👍

@theOehrly theOehrly merged commit e9832ee into theOehrly:master May 19, 2023
@Casper-Guo Casper-Guo deleted the laptimes-distribution-example branch June 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants