-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team pace ranking example #420
Conversation
The Can be disabled with |
It's not really a false positive. It's complaining because I don't really want to disable the warning in pandas entirely. You'd need to explain that line of code as well then. Maybe the best solution would be to slightly modify the example so that the problem does not occur? Is that possible without making the code much more complicated? Just don't create the column in the exisiting dataframe but keep the data as a separate variable or create a new DataFrame? What do you think? |
Should be a very simple modification, will look into it |
d13faa9
to
6c222e9
Compare
Got rid of the warning, everything looks decent in the build now |
6c222e9
to
750f46c
Compare
Yes I forgot that detail. I've edited all the block comments. Just need to fix a typo |
750f46c
to
d556eba
Compare
All good now, in my opinion. I can merge this? Or is there anything you want to change still? I'm a bit confused by your comment about the typo 😅 |
Ah sorry I forgot to update the comment after my last push. Everything ready to merge now. |
Produce the following plot: