Small improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
This will fix a problem with commonjs and es6 between vue and protobuf.js See for this grpc/grpc-web#237 Here is a possbile fix described: improbable-eng/ts-protoc-gen#111 vuejs/vue-cli#2586 Signed-off-by: solidnerd <niclas@mietz.io>
|
Hey @solidnerd Thanks for the PR, It looks really great. I am new to docker and through this PR I was able to grasp how docker and docker compose works. I really appreciate your effort to make this app better ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
thanks for this great blog article. It was easy to get in and very understandable. I made some improvements. If you want to you can use them or we can discuss them here directly in the pull request.