Make conway updating considerably faster #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is redundant to independently check if b is 3 and state is 1, and if so set c to 1, and check if b is 3 and state is 0, and if so set c to 1. Fold these into one check. Additionally, to reduce number of array lookups, fold the remaining two operations into one. Thirdly, in newer numpy versions numpy.where() is redundant, and slower than using the array[array condition] syntax
scipy has a method for convolution now
The other one is faster, but it requires using a merely (3,3) kernel rather than one the size of the full state, so it isn't no-changes compatible, and it requires scipy so the travis build fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is redundant to independently check if b is 3 and state is 1, and if so set c to 1, and check if b is 3 and state is 0, and if so set c to 1.
Fold these into one check.
Additionally, to reduce number of array lookups, fold the remaining two operations into one. using a bitwise or
Thirdly, in newer numpy versions numpy.where() is not necessary in this case, and is slower than using the array[array condition] syntax
EDIT: correction to the "revert convolution change" commit message, it turns out that if you just shift the filter to the up-left by one the scipy.signal convolution method works. Still not no-changes compatible with the other code so not including.