Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must also define legal false values in .pydeps #21

Closed
thebjorn opened this issue Feb 13, 2019 · 0 comments
Closed

Must also define legal false values in .pydeps #21

thebjorn opened this issue Feb 13, 2019 · 0 comments
Labels
blocker Issue blocks next release. bug

Comments

@thebjorn
Copy link
Owner

Related to the fix for #20. True values are defined here:

pydeps/pydeps/arguments.py

Line 27 in 2672f43

return v in {'j', 'y', 'ja', 'yes', '1', 'true'}

Without this any typo would count as True which would "be bad".
@thebjorn thebjorn added bug blocker Issue blocks next release. labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker Issue blocks next release. bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thebjorn