Switch to uploading static assets during deploy #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we run the same version everywhere. Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
That's the only context where we use Docker for development. We should probably add something about Typesense to CONTRIBUTE.md, but since I don't use it, now isn't a good time to tackle this. Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
We talked about this in Kaizen 13, it's not something that we support. Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
Since uploading static assets requires a db connection - doesn't seem right, but it is what it is - and prod config requires Postgres to use SSL, and we should not connect to the production db from the CI, the only option is to upload these on app boot, just before we run db migrations. If uploading static assets would not require a db connection, this would definitely be a CI concern, but for now this is the simplest fix. Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading static assets, this addresses the SSL issue introduced by:
More details in the commit messages.