Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package-Level Makefiles for Testing #587

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Package-Level Makefiles for Testing #587

merged 1 commit into from
Jul 19, 2017

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented Jul 18, 2017

This patch introduces package-level Makefiles for driving tests for the libStorage framework as well as the storage drivers.

@akutz akutz self-assigned this Jul 18, 2017
@akutz akutz requested a review from codenrhoden July 18, 2017 20:26
@akutz akutz force-pushed the feature/pkg-level-test-makefiles branch from f9062c2 to 247bc69 Compare July 18, 2017 20:27
codenrhoden
codenrhoden reviewed Jul 18, 2017
View reviewed changes
Copy link
Contributor

@codenrhoden codenrhoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to not duplicate all the package level Makefiles? a symlink to a master version or something? I've never committed a symlink to git, though I know it's possible, but I'm not sure of the ramifications.

I do like all the latest changes. will make the project easier to work on by all, and more approachable.

@akutz
Copy link
Collaborator Author

akutz commented Jul 18, 2017

Hi @codenrhoden,

A symlink is possible and so is placing a file at the top level called driver-tests.mk or framework-tests.mk and then in the individual directories including a Makefile that has a single line:

include ../../../driver-tests.mk

Or something like that.

The reason I didn't opt for referencing a file at the root of the project is for portability. We plan to break the drivers out into other repos, and so I didn't want to link to anything at the root of this one. Does that make sense?

@akutz akutz force-pushed the feature/pkg-level-test-makefiles branch 3 times, most recently from 9e263b6 to cc80547 Compare July 19, 2017 17:17
@akutz
Package-Level Makefiles for Testing
cc80547 
This patch introduces package-level Makefiles for driving tests for the
libStorage framework as well as the storage drivers.
codenrhoden
codenrhoden approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@codenrhoden codenrhoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More simplifications! I love it.

I know that shows I don't understand go coverage all that well, but why isn't TEST_COVERPKG necessary anymore?

@akutz akutz merged commit a744db8 into thecodeteam:master Jul 19, 2017
@akutz akutz deleted the feature/pkg-level-test-makefiles branch July 19, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codenrhoden codenrhoden codenrhoden approved these changes

Assignees

@akutz akutz

Labels
build enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akutz @codenrhoden