Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PECL uploadprogress on fat image #112

Closed
ghost opened this issue Jan 8, 2019 · 4 comments · Fixed by #182
Closed

Missing PECL uploadprogress on fat image #112

ghost opened this issue Jan 8, 2019 · 4 comments · Fixed by #182

Comments

@ghost
Copy link

ghost commented Jan 8, 2019

Expected Behavior

When using image for Drupal I expect to see the PECL uploadprogress library on the image.

Current Behavior

Not present. Drupal status report page mentions it not being enabled.

Possible Solution

RUN git clone https://github.com/php/pecl-php-uploadprogress/ /usr/src/php/ext/uploadprogress/ \
&& docker-php-ext-configure uploadprogress \
&& docker-php-ext-install uploadprogress \
&& rm -rf /usr/src/php/ext/uploadprogress

Context

This is really dependent on whether your project requires the uploadprogress library. Just thought I'd share with you my work.

Environment

@ghost ghost changed the title Missing PECL uploadlibrary on fat image Missing PECL uploadprogress on fat image Jan 8, 2019
@moufmouf
Copy link
Member

moufmouf commented Jan 8, 2019

I'll look into it.

Seems a pretty old extension. Last update is from 2015 and I cannot compile it using pecl install uploadprogress.

Build seems to be kind of working from the "master" branch but I'm kind of reluctant to rely on a master branch. Last tag is from 2011...

Is it used in latest versions of Drupal?

@ghost
Copy link
Author

ghost commented Jan 8, 2019

Yeah well, Drupal 8 doesn't require it. But to enable upload progress it asks to install the library:
https://www.drupal.org/node/793264

Again this is just a proposition. I understand that you want to give generic php support. And you're correct in saying that it's pretty old and probably not many frameworks rely on it.

@moufmouf
Copy link
Member

Hey @verbruggenalex ,

I'm closing this issue as it is quite old. I don't have any plans to add uploadprogress as it is clearly unmaintained and will certainly lead to problems down the road as PHP evolves.

@moufmouf
Copy link
Member

Reopening this issue as the uploadprogress extension has recently been updated!

https://twitter.com/ramsey/status/1221667202086162433

We can now add it to the fat PHP images

@moufmouf moufmouf reopened this Jan 28, 2020
moufmouf added a commit to moufmouf/docker-images-php that referenced this issue Jan 28, 2020
Following the recent update of the extension, we can now consider including it in the FAT image.
Closes thecodingmachine#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant