Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend documentation about CMD / ENTRYPOINT for CLI #132

Closed
iquito opened this issue May 8, 2019 · 2 comments
Closed

Amend documentation about CMD / ENTRYPOINT for CLI #132

iquito opened this issue May 8, 2019 · 2 comments

Comments

@iquito
Copy link
Contributor

iquito commented May 8, 2019

When using the CLI images, it is implied that you should set a CMD (and this is shown in the one CLI example via command line), but it would help if at least one docker compose example and/or Dockerfile example showed this explicitely - it could be a CLI example running phpunit, which would be a common use case.

I tried setting up an ENTRYPOINT instead of a CMD, which overwrote the ENTRYPOINT of the image and lead to unexpected results (like php.ini settings not being set up), so a warning not to use ENTRYPOINT in a Dockerfile might also help, as most docker tutorials advise on using ENTRYPOINT instead of CMD, or using both together for executable containers.

moufmouf added a commit to moufmouf/docker-images-php that referenced this issue Jun 20, 2019
As suggested by thecodingmachine#132, this PR adds documentation regarding the dos and don'ts of using the CLI variant of the image.
@moufmouf
Copy link
Member

Hey @iquito ,

Thanks for the advices. Indeed, a bit of work on the documentation is always good.
I opened this PR. #137

@iquito
Copy link
Contributor Author

iquito commented Jun 20, 2019

The PR solves this perfectly, thanks! And thanks for all the work on these great docker images in general, they are really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants