Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A big THANK YOU is in order #57

Closed
peterbe opened this issue Apr 16, 2021 · 1 comment
Closed

A big THANK YOU is in order #57

peterbe opened this issue Apr 16, 2021 · 1 comment

Comments

@peterbe
Copy link

peterbe commented Apr 16, 2021

Cheekily, just wanted to abuse an issue for a good cause.

MDN Web Docs (now) uses fdir and it's looking extremely promising.
We used to use glob.sync() and a whole mixed bag of other path.join() and tricky stuff.
Today I was able to replace all of it with fdir and I did it in such a way that I kept the old function so I could compare.

All the numbers are in mdn/yari#3537 and it might be a bit hard to read, but "So basically, the new function is 10x faster." is easy to understand :)

Awesome work!

Also, how I wish Node could get a low-level C++ native implementation, in the standard library, of path.join() and those guys to make this problem go away.

@peterbe peterbe closed this as completed Apr 16, 2021
@thecodrr
Copy link
Owner

🤯 I was not expecting this!

I am absolutely flabbergasted that yari is now using fdir. I checked the numbers and wow! I mean I have benchmarked myself but seeing independent numbers...is something else.

I am glad you found fdir 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants