Feature make character of PaginationEllipsis configurable #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And set the default character to "…" instead of "…", because "…" was not displayed correctly with the latest version of yew.
thedodd
reviewed
Apr 11, 2023
src/components/pagination.rs
Outdated
| @@ -95,13 +95,20 @@ pub enum PaginationItemType { | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////////////// | |||
| ////////////////////////////////////////////////////////////////////////////// | |||
| /// | |||
There was a problem hiding this comment.
Might be good to add a simple doc string here.
thedodd
requested changes
Apr 11, 2023
|
Very simple doc string added and I also updated changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And set the default character to "…" instead of "…", because "…" was not displayed correctly with the latest version of yew.
Before:
After:
