Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variables for authentication #866

Closed
wants to merge 2 commits into from

Conversation

willtome
Copy link
Contributor

@willtome willtome commented Jul 8, 2020

Updates doc fragment to use environment variables consistent with inventory plugin.
Updates inventory plugin to use doc fragment rather than its own options.

Resolves Issue #837

@evgeni
Copy link
Member

evgeni commented Jul 8, 2020

Doesn't this require to add fallback to the argument spec as described in https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#fallback to work in the modules too?

argument_spec = dict(
server_url=dict(required=True),
username=dict(required=True),
password=dict(required=True, no_log=True),
validate_certs=dict(type='bool', default=True),
)

@willtome
Copy link
Contributor Author

willtome commented Jul 8, 2020

🤦‍♂️ you're right. missed that. going to close for now and come back when I've got it right for plugins AND modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants