-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #4570 - display AIX version differently #1286
Conversation
[test] |
@joshuabaird you forgot to update the AIX test :)
|
Ok, lets try this again :) |
[test] |
Looks good to me and it parses the facts as expected, I'd say ready to merge if nobody has any issues with the PR. |
@elobato please hold off, there was a discussion on the ticket |
@elobato, @domcleal, @joshuabaird, what's the result of the discussion on this ticket? |
A bit undecided, but either leaving it as is, or a slightly different variant. Best yet would probably be to allow the OS model to have different versioning schemes based on the family or configuration, as we have minor issues in other OS family types. |
Did we reach any consensus on this? From what I see on the issue not really, I believe allowing alphanumeric characters in major minor would be more flexible. Allowing different versioning schemes defined by us via Family sounds good too. @joshuabaird what do you think? Do you plan to work on this in the near future? If not I suggest we close this off and reopened later if needed. |
@joshuabaird @domcleal ping? |
closing due to lack of activity, please re-open if something changes |
Previously, AIX versions were displayed as "AIX 7100.0301" With this commit, they are now displayed like "AIX 7.1" where major=7 and minor=1. Previously, the other values included service pack and technology levels which doesn't really belong in the main operating system version.