Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4570 - display AIX version differently #1286

Closed
wants to merge 2 commits into from

Conversation

joshuabaird
Copy link
Member

Previously, AIX versions were displayed as "AIX 7100.0301" With this commit, they are now displayed like "AIX 7.1" where major=7 and minor=1. Previously, the other values included service pack and technology levels which doesn't really belong in the main operating system version.

@domcleal
Copy link
Contributor

[test]

@GregSutcliffe
Copy link
Member

@joshuabaird you forgot to update the AIX test :)

<"6100"> expected but was
<"6">. (test_0016_should set os.major and minor for from AIX facts)

@joshuabaird
Copy link
Member Author

Ok, lets try this again :)

@domcleal
Copy link
Contributor

[test]

@dLobatog
Copy link
Member

Looks good to me and it parses the facts as expected, I'd say ready to merge if nobody has any issues with the PR.

@domcleal
Copy link
Contributor

@elobato please hold off, there was a discussion on the ticket

@isratrade
Copy link
Member

@elobato, @domcleal, @joshuabaird, what's the result of the discussion on this ticket?

@domcleal
Copy link
Contributor

domcleal commented Jul 1, 2014

A bit undecided, but either leaving it as is, or a slightly different variant. Best yet would probably be to allow the OS model to have different versioning schemes based on the family or configuration, as we have minor issues in other OS family types.
http://projects.theforeman.org/issues/4570

@dLobatog
Copy link
Member

dLobatog commented Oct 1, 2014

Did we reach any consensus on this? From what I see on the issue not really, I believe allowing alphanumeric characters in major minor would be more flexible. Allowing different versioning schemes defined by us via Family sounds good too.

@joshuabaird what do you think? Do you plan to work on this in the near future? If not I suggest we close this off and reopened later if needed.

@dLobatog
Copy link
Member

dLobatog commented Dec 3, 2014

@joshuabaird @domcleal ping?

@ohadlevy
Copy link
Member

closing due to lack of activity, please re-open if something changes

@ohadlevy ohadlevy closed this Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reached an impasse Needs broader discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants