Fixes #6606 - Allow deletion of non-admin users if there's only one admin #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to apologize. Reproduced, tested, works for me, unit tests green. Thanks for the contribution. |
|
Mind adding one extra test for this? |
|
@lzap will do. EDIT: Updated with a test. |
When deleting users, you get an error message if there's only one admin account even if the users aren't admins.
|
Thanks @daviddavis, merged as 7096627 for Foreman 1.6.0. |
timogoebel
added a commit
to timogoebel/foreman
that referenced
this pull request
Dec 9, 2015
timogoebel
added a commit
to timogoebel/foreman
that referenced
this pull request
Dec 9, 2015
timogoebel
added a commit
to timogoebel/foreman
that referenced
this pull request
Dec 9, 2015
domcleal
pushed a commit
that referenced
this pull request
Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if this is a dupe but I searched and didn't see anything in redmine/github.