Fixes #9836 - use provider type in host helpers #2247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ module HostsHelper | |||
| def provider_partial_exist?(compute_resource, partial) | |||
| return false unless compute_resource | |||
|
|
|||
| compute_resource_name = compute_resource.provider_friendly_name.downcase | |||
| compute_resource_name = compute_resource.provider.downcase | |||
| real_path = File.join(Rails.root, 'app', 'views', 'compute_resources_vms', 'form', compute_resource_name, "_#{partial}.html.erb") | |||
There was a problem hiding this comment.
Side note, this doesn't look plugin-friendly, as it's referencing Rails.root rather than a search path.
|
@tstrachota 👍 from my side, can you take a look at @domcleal 's comment if possible? Ready to merge in my opinion. |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Merged as c2f60b5, thanks @tstrachota ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.