Fixes #12106 - Show popovers correctly on interface modal #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
@tbrisker Interesting! It fixes the issue well. The hidden help text admittedly looks better IMO, do you agree @ares @tstrachota ? If you can, do you mind to write an integration test that checks the popovers work well after saving an interface and reopening it? It's kind of an obscure change that could very easily break. Since the other part of this PR (the help text) is no-risk and already makes it better, would you submit a separate PR & issue number, etc.. with that? I think it'd be merged now already. Thanks again! |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
When saving an interface the popovers were not destroyed, leading to them breaking when opening the same interface form again.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Tested. Works very well 👍 |
|
@tbrisker Fine, but I'll nag you if this comes as a regression later 😄 |
|
Merged as 988cee4, thanks @tbrisker & @shlomizadok ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving an interface the popovers were not destroyed, leading to
them breaking when opening the same interface form again.
Also, the help text for the various checkboxes has been hidden with
popover to reduce screen clutter.