Fixes #4629 - Migrate UI to Patternfly #2943

alongoldboim · 2015-11-30T10:21:30Z

No description provided.

theforeman-bot · 2015-11-30T10:21:36Z

There were the following issues with the commit message:

40eba16 must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

ohadlevy · 2015-11-30T11:17:43Z

when viewing facts (monitor -> facts) sorting the table based on value shows empty screen.

ohadlevy · 2015-11-30T11:18:28Z

i take it back, it was an error on my browser-sync setup.

ohadlevy · 2015-11-30T11:41:01Z

icon colors are blue, not sure if its on purpose, but imho black background looks better.
also, if we switch to font-awesome, their background would be black.

ohadlevy · 2015-11-30T13:25:21Z

under host edit, all inherit buttons are not aligned

theforeman-bot · 2015-12-01T10:55:56Z

There were the following issues with the commit message:

12d9014 must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

theforeman-bot · 2015-12-01T11:56:52Z

There were the following issues with the commit message:

12858b5 must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

…ut helper, added in Host and hostgroup root_pass, LDAP acount password, BMC password and compute resources password theforeman#2943,#11387 - Please enter the commit message for your changes. Lines starting

theforeman-bot · 2015-12-02T16:13:57Z

There were the following issues with the commit message:

73c3810 must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

theforeman-bot · 2015-12-03T09:04:22Z

There were the following issues with the commit message:

2d6be5a must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

ohadlevy · 2016-01-04T07:58:02Z

app/views/dashboard/_reports_widget.html.erb

@@ -5,7 +5,7 @@
 <% if events.empty? %>
  <p class="ca"><%= _("No interesting reports received in the last week") %></p>
 <% else %>
-  <table class="table table-striped ellipsis">
+  <table class="table table-striped table-bordered ellipsis">


css table helper?

alongoldboim · 2016-01-04T14:01:47Z

@ohadlevy @dLobatog

removed vendored jsnotify change, used jquery to replace.
fixed nitpicks
changed welcome pages to icons to use icon_text helper, changed helpers to use span instead of i tag
add issues that need to be addressed once this pr is merged:
http://projects.theforeman.org/issues/12972
http://projects.theforeman.org/issues/12945
http://projects.theforeman.org/issues/12979

ohadlevy · 2016-01-05T11:46:32Z

config/initializers/assets_paths.rb

@@ -0,0 +1,14 @@
+plugins = Rails.application.railties.select { |e| e.railtie_name.match /foreman/ }


imho worth a comment about what this is all about

added comment.

dLobatog · 2016-01-07T08:24:35Z

config/initializers/assets_paths.rb

@@ -0,0 +1,20 @@
+=begin


@alongoldboim Use plain old # comments, rubocop is failing because of this block

dLobatog · 2016-01-07T08:29:48Z

@alongoldboim The test failure seems like it's not caused by this. I can fix the rubocop violation & use the table css helper class that @ohadlevy recommended on merge.

alongoldboim · 2016-01-07T08:32:20Z

@dLobatog talked with @ohadlevy , agreed on applying the use of table_css helper app wide on a diff pr.

dLobatog · 2016-01-07T09:52:45Z

Merged as aa50ab1, thanks @alongoldboim for picking this one up, and @ohadlevy @ehelms @shlomizadok @tbrisker for doing the reviews.

See theforeman/foreman@aa50ab1#diff-befe6bd0bbaad6cb7d8ed3858726bd64R13 or theforeman/foreman#2943 (comment) for more information.

theforeman-bot added Waiting on contributor Not yet reviewed Needs testing labels Nov 30, 2015

alongoldboim force-pushed the 4629 branch from 40eba16 to 12d9014 Compare December 1, 2015 10:55

theforeman-bot added Needs testing Waiting on contributor and removed Waiting on contributor labels Dec 1, 2015

alongoldboim force-pushed the 4629 branch from 12d9014 to 12858b5 Compare December 1, 2015 11:56

theforeman-bot added Needs testing Waiting on contributor and removed Waiting on contributor labels Dec 1, 2015

alongoldboim force-pushed the 4629 branch from 12858b5 to 73c3810 Compare December 2, 2015 16:13

theforeman-bot added Needs testing and removed Waiting on contributor labels Dec 2, 2015

theforeman-bot added the Waiting on contributor label Dec 2, 2015

alongoldboim force-pushed the 4629 branch from 73c3810 to 2d6be5a Compare December 3, 2015 09:04

theforeman-bot added Needs testing Waiting on contributor and removed Waiting on contributor labels Dec 3, 2015

alongoldboim force-pushed the 4629 branch from 2d6be5a to c965385 Compare December 3, 2015 09:14

ohadlevy reviewed Jan 4, 2016
View reviewed changes

alongoldboim force-pushed the 4629 branch 2 times, most recently from 8d3dec4 to 39cf32b Compare January 4, 2016 13:57

ohadlevy reviewed Jan 5, 2016
View reviewed changes

alongoldboim force-pushed the 4629 branch from 39cf32b to 9ff961f Compare January 5, 2016 12:59

Fixes theforeman#4629 - Migrate UI to Patternfly

fe16a84

alongoldboim force-pushed the 4629 branch from 9ff961f to fe16a84 Compare January 5, 2016 16:22

dLobatog reviewed Jan 7, 2016
View reviewed changes

domcleal closed this Jan 7, 2016

dLobatog mentioned this pull request Jan 11, 2016

Use :before => finisher_hook to load assets before sprockets theforeman/foreman_plugin_template#11

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #4629 - Migrate UI to Patternfly #2943

Fixes #4629 - Migrate UI to Patternfly #2943

alongoldboim commented Nov 30, 2015

theforeman-bot commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

theforeman-bot commented Dec 1, 2015

theforeman-bot commented Dec 1, 2015

theforeman-bot commented Dec 2, 2015

theforeman-bot commented Dec 3, 2015

ohadlevy Jan 4, 2016

alongoldboim commented Jan 4, 2016

ohadlevy Jan 5, 2016

alongoldboim Jan 5, 2016

dLobatog Jan 7, 2016

dLobatog commented Jan 7, 2016

alongoldboim commented Jan 7, 2016

dLobatog commented Jan 7, 2016

		@@ -0,0 +1,14 @@
		plugins = Rails.application.railties.select { \|e\| e.railtie_name.match /foreman/ }

Fixes #4629 - Migrate UI to Patternfly #2943

Fixes #4629 - Migrate UI to Patternfly #2943

Conversation

alongoldboim commented Nov 30, 2015

theforeman-bot commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

ohadlevy commented Nov 30, 2015

theforeman-bot commented Dec 1, 2015

theforeman-bot commented Dec 1, 2015

theforeman-bot commented Dec 2, 2015

theforeman-bot commented Dec 3, 2015

ohadlevy Jan 4, 2016

Choose a reason for hiding this comment

alongoldboim commented Jan 4, 2016

ohadlevy Jan 5, 2016

Choose a reason for hiding this comment

alongoldboim Jan 5, 2016

Choose a reason for hiding this comment

dLobatog Jan 7, 2016

Choose a reason for hiding this comment

dLobatog commented Jan 7, 2016

alongoldboim commented Jan 7, 2016

dLobatog commented Jan 7, 2016