refs #2445 - move back FreeBSD icon #3194
Conversation
|
@mmoll If you check the helper that displays this icon, it uses the right capitalization @bkearney changed it to - https://github.com/theforeman/foreman/blob/develop/app/helpers/operatingsystems_helper.rb#L28 Maybe you're not seeing it for some other reason? |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
I'm not getting it, the capitalization in that file is |
|
@dLobatog can you please check https://bugzilla.redhat.com/show_bug.cgi?id=1283668. This is what caused me to change it. |
|
@bkearney I think that happened because the name of the OS created was not 'Freebsd' (case insensitive). Family is not enough to show the icon in Foreman, the name has to match an OS. Otherwise Ubuntu would show up with the Debian family icon instead of Ubuntu, CentOS as Red Hat, etc... |
|
@dLobatog so, how should I fix that bug? |
|
@bkearney I think in that BZ the user created an OS with the name Freebsd and family FreeBSD, while both need to be FreeBSD, as this is the name by the fact, Facter is returning. |
|
Nope, name 'freebsd', or 'Freebsd', etc.. all work. The person who opened the bug chose 'family FreeBSD' but the OS name had a different name. If the name doesn't contain 'freebsd' in it (regardless of capitalization) it won't show any icon. I don't think that needs to be fixed? |
f6014fb broke display of the icon on the hosts page for me. Or am I missing something in the Debian nightlies?