Fixes #13964 - include installer scenarios in foreman-debug #3260
Conversation
mbacovsky
commented
Mar 1, 2016
mbacovsky
commented
- added paths to the installer configs and logs including migrations
- fixed the add_files to really accept symlinks. The file filter let them in but they were refused by mime-type filter
- fixed case's "else" to log skipped files
- during debugging I found out that XML files were silently skipped so I've added a fix as well, can be removed from this PR as it is not related to the issue (let me know if it is the case)
| @@ -298,6 +299,7 @@ add_cmd "echo 'select type,name,host,port,account,base_dn,attr_login,onthefly_re | |||
| add_cmd "foreman-selinux-relabel -nv" "foreman_filecontexts" | |||
|
|
|||
| add_files /etc/{sysconfig,default}/foreman | |||
| add_files /etc/{sysconfig,default}/foreman-installer/scenarios.d/{*,*/*,*/.*} | |||
There was a problem hiding this comment.
I don't think there any files like this?
Should it store actual symlinks in the tarball? It appears to be copying the contents of the file in, so you end up with two copies of it. Perhaps knowing that a certain file (e.g. last_scenario.yaml) actually is a symlink and where it's pointing to might be useful to know. |
|
@domcleal yeah it would makes sense to store the symlinks. I tried to store them as is, which is problem in non-relative links. Do you prefer to store the link as it was (to see where it pointed to originaly on the system) or update the link to be functional and point to file in the foreman-debug tarball? |
|
I'd say just store it as-is, there's less chance of it going wrong and it would be clearer if you're trying to debug something from the information. |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Symlinks added, archiving non-existing files from /etc/sysconfig removed, |
|
Merged as 91e0340, thanks @mbacovsky. |
