Fixes #16020 - Prevent reflective XSS on form validation #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error messages for various form fields were not properly escaped to prevent HTML from being insert into them. This caused a possible reflective XSS in smart class parameter/varaible default value validations.
|
To the reviewer: please note that this was reported to foreman-security, though it appears to have no noticeable security impact, as the XSS is not stored. For this reason, no CVE will be requested, it's just a preventative measure. |
|
I looked for instances of We call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages for various form fields were not properly escaped to
prevent HTML from being insert into them. This caused a possible
reflective XSS in smart class parameter/varaible default value
validations.