Fixes #16379 - Improve layout of hostname randomize button #3792
Conversation
|
Before: After: @Rohoover - I'd be happy for your input |
|
I think it deserves its own redmine issue. |
tbrisker
changed the title
|
@ares thanks, updated |
|
Works nicely, ACK pending jenkins and feedback from @Rohoover |
|
@tbrisker how about having it as a btn inside the input, similar to the date picker at https://www.patternfly.org/pattern-library/forms-and-controls/date-picker ? |
|
Visually I am not bothered by either approach so I have to default to the closest standard for consistency which would be what @ohadlevy suggested. Leaving it "naked" without the button would be a new pattern or exception. |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
| @@ -331,14 +320,15 @@ def field(f, attr, options = {}) | |||
| yield | |||
| end.html_safe | |||
| else | |||
| form_feedback = content_tag(:span, options.delete(:form_feedback), :class => "form-control-feedback") | |||
There was a problem hiding this comment.
Useless assignment to variable - form_feedback.
This moves the button from being a line of its own to a button in the input. Also changed the form helper to streamline adding button to inputs and got rid of a useless helper.
|
Changed to a button, updated screenshot: |
|
@tbrisker what do you see if the feature is disabled? |
|
@ohadlevy just a regular text input with no button |
|
ack assuming this is the right icon to use (didnt find a better one). |
|
This is the correct icon. It's labeled as such in font awesome and is the generally accepted icon for "random" in a multitude of applications. +1 |
|
Works as expected, thanks. |
|
[test] |
|
Merged as 3b6f932, thank you! |
This moves the button from being a line of its own to an icon inside the
input. Also added a form_feedback option to the field helper to allow
easy addition of more icons in inputs in the future.