fixes #19087 - create host built notification from Host#built #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing the host's installed_at timestamp is unreliable on MySQL databases, as the timestamp field has a limited granularity. Under Rails 5 in a sub-second test, this field will not be changed. Instead, extend Host#built to create notifications as the original method is also used to send e-mail notifications and update the installed_at field.
|
@domcleal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @iNecas, @ohadlevy and @GregSutcliffe to be potential reviewers. |
|
thanks @domcleal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the host's installed_at timestamp is unreliable on MySQL
databases, as the timestamp field has a limited granularity. Under Rails
5 in a sub-second test, this field will not be changed.
Instead, extend Host#built to create notifications as the original
method is also used to send e-mail notifications and update the
installed_at field.