Fixes #19762 - upgrade to rubocop 0.49.1 #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbrisker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @shlomizadok, @domcleal and @timogoebel to be potential reviewers. |
houndci-bot
reviewed
Jun 4, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/DotPosition has the wrong names...
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/EmptyLinesAroundAccessModifier has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/IndentAssignment has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/MultilineArrayBraceLayout has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/MultilineHashBraceLayout has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/MultilineMethodCallBraceLayout has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/MultilineMethodCallIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceAroundBlockParameters has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceInsideBrackets has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout
/tmp/d20170604-6184-6iy16/.rubocop.yml: Style/SpaceInsidePercentLiteralDelimiters has the wrong namespace - should be Layout
Error: TheStyle/MethodCallParenthesescop has been renamed toStyle/MethodCallWithoutArgsParentheses.
(obsolete configuration found in /tmp/d20170604-6184-6iy16/.rubocop.yml, please update it)
|
@tbrisker does it make sense to enable some of those new cops? at some point of time we should start reducing the number of todo's :) |
|
@ohadlevy in general - yes, definitely. I'd rather do that in separate PRs though, so this PR doesn't get blocked by disagreements on which cops should be enabled and which not. |
|
@ohadlevy all 🍏 except the regular katello failures |
|
Thank @tbrisker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.