Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23587 - Verify webpack precompile is needed #5558

Merged
merged 1 commit into from
May 15, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 14, 2018

Plugins like bastion do have a package.json but no webpack resources.

Should fix http://koji.katello.org/koji/watchlogs?taskID=98491:

/builddir/build/BUILD/bastion-6.1.10/usr/share/foreman/node_modules/webpack/bin/webpack.js --config /builddir/build/BUILD/bastion-6.1.10/usr/share/foreman/config/webpack.config.js --bail --env.pluginName=bastion
/builddir/build/BUILD/bastion-6.1.10/usr/share/foreman/config/webpack.config.js:37
    var outputPath = path.join(plugins['plugins'][env.pluginName]['root'], 'public', 'webpack');
                                                                 ^
TypeError: Cannot read property 'root' of undefined
    at module.exports.env (/builddir/build/BUILD/bastion-6.1.10/usr/share/foreman/config/webpack.config.js:37:66)
    at handleFunction (/usr/lib/node_modules/webpack/lib/prepareOptions.js:26:13)
    at prepareOptions (/usr/lib/node_modules/webpack/lib/prepareOptions.js:11:13)
    at requireConfig (/usr/lib/node_modules/webpack/bin/convert-argv.js:98:14)
    at /usr/lib/node_modules/webpack/bin/convert-argv.js:104:17
    at Array.forEach (native)
    at module.exports (/usr/lib/node_modules/webpack/bin/convert-argv.js:102:15)
    at Object.<anonymous> (/usr/lib/node_modules/webpack/bin/webpack.js:155:40)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:389:7)
    at startup (bootstrap_node.js:149:9)
rake aborted!

@theforeman-bot
Copy link
Member

Issues: #23587

@ekohl ekohl changed the title Fixes #23587 - Allow building webpack for bastion [WIP] Fixes #23587 - Allow building webpack for bastion May 14, 2018
Plugins like bastion do have a package.json but no webpack resources.
@ekohl ekohl changed the title [WIP] Fixes #23587 - Allow building webpack for bastion Fixes #23587 - Verify webpack precompile is needed May 14, 2018
@pcreech
Copy link
Member

pcreech commented May 15, 2018

ACK

@ohadlevy ohadlevy merged commit 5b18338 into theforeman:develop May 15, 2018
@ohadlevy ohadlevy added this to the 1.18.0 milestone May 15, 2018
@ekohl ekohl deleted the 23587-bastion-webpack branch May 27, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants