Fixes #27442 - deprecation mysql warning #6938

lzap · 2019-07-29T10:21:05Z

A notification that warns about MySQL in a non-intrusive way similarly that we did for deprecated settings about a year ago.

Edit: Based off: https://github.com/theforeman/foreman/pull/6038/files

theforeman-bot · 2019-07-29T10:21:18Z

Issues: #27442

lzap · 2019-07-29T10:21:59Z

This points to a non-existing blogpost: theforeman/theforeman.org#1404

ares

looks reasonable to me (haven't tested yet), confirmation from @tbrisker and @ekohl who were mostly active in the discourse thread would be great

given it works, I wouldn't mind merging, of there are no objections

ares · 2019-07-29T10:43:55Z

config/application.rb

+    def notify_deprecations
+      if ActiveRecord::Base.connection.adapter_name.downcase.starts_with?('mysql')
+        blueprint = NotificationBlueprint.find_by_name('feature_deprecation')
+        Foreman::Deprecation.deprecation_warning('1.24', "Support for MySQL is deprecated, migrate to PostgreSQL")


there was a discussion to postpone this by one version, is it 1.24 now then?

Yeah, changing to 1.25.

ezr-ondrej

The implementation looks quite good. I would move it to separate file, though...

ezr-ondrej · 2019-07-29T11:06:42Z

config/application.rb

@@ -343,6 +344,30 @@ def init_dynflow
    def setup_auditing
      Audit.send(:include, AuditSearch)
    end
+
+    def notify_deprecations


wouldn't it be better to have a sepparate config/initializers/<i.e. depracate_mysql.rb> file?

Yes, we actually have an existing deprecations.rb initializer, so moving it there.

tbrisker · 2019-07-29T11:12:14Z

I'll be ok with pulling this in post branching, and would prefer to properly review the migration instructions and blog post not on the same day as branching. I think also 1.25 is more reasonable so users have enough time to prepare and for us to test the migration, and i'll comment to that effect on the discourse thread.

config/application.rb

ares · 2019-07-29T11:28:46Z

I'll be ok with pulling this in post branching, and would prefer to properly review the migration instructions and blog post not on the same day as branching.

ack, I won't touch it :-)

lzap · 2019-07-29T11:54:10Z

Incorporated all comments, rebased, fixed bug when blueprint was not present (database was not yet seeded). I am using "1.25/2.0" in the notification text, however I keep "1.25" in Foreman::Deprecation.deprecation_warning because we use that in our codebase and we will likely replace this once we do the final decision about 2.0.

ezr-ondrej

I hate rockets (=>) 🚀
Otherwise LGTM 👍

tbrisker · 2019-07-31T09:33:14Z

Mysql tests are failing, i guess because of the deprecation warning - we need to add it to the whitelist

config/initializers/deprecations.rb

lzap · 2019-08-01T08:25:34Z

Removed 2.0, added to the whitelist, rebased.

ezr-ondrej · 2019-08-01T09:40:16Z

config/initializers/deprecations.rb

+        Foreman::Deprecation.deprecation_warning('1.25', "Support for MySQL is deprecated, please migrate to PostgreSQL")
+        blueprint = NotificationBlueprint.find_by_name('feature_deprecation')
+        return unless blueprint
+        message = UINotifications::StringParser.new(blueprint.message, {feature: 'MySQL as a backend database', version: '1.25'}).to_s


Other notifications got its classes and define theirs initialize, if we want to have a generick deprecation class, wouldn't it great to have such class, which would encapsulate these?

Sorry what? ;-) Can you provide an example code?

tbrisker · 2019-09-04T13:19:49Z

config/initializers/deprecations.rb

+          :actions => {
+            :links => [
+              {
+                :href => 'https://theforeman.org/2019/08/dropping-support-for-mysql.html',


We'll need to update this once we get the post published.

https://theforeman.org/2019/09/dropping-support-for-mysql.html

tbrisker

please update the link and rebase on latest develop, otherwise gtg

tbrisker · 2019-09-04T13:59:37Z

config/initializers/deprecations.rb

+          :actions => {
+            :links => [
+              {
+                :href => 'https://theforeman.org/2019/08/dropping-support-for-mysql.html',


https://theforeman.org/2019/09/dropping-support-for-mysql.html

lzap · 2019-09-05T11:48:38Z

Done.

tbrisker

Thanks @lzap ! just installed mysql to verify and this works well.

tbrisker · 2019-09-05T13:50:58Z

config/as_deprecation_whitelist.yaml

@@ -14,3 +14,6 @@
 # https://projects.theforeman.org/issues/23300
 - message: 'Dangerous query method (method whose arguments are used as raw SQL) called
    with non-attribute argument(s):'
+
+# https://projects.theforeman.org/issues/27035
+- message: 'Support for MySQL is deprecated, migrate to PostgreSQL'


Looks like this only works inside tests? mysql tests are failing to run with:
/usr/local/rvm/gems/ruby-2.5.1@test_develop_pr_core-3/gems/activesupport-5.2.1/lib/active_support/lazy_load_hooks.rb:69:in block in execute_hook': DEPRECATION WARNING: You are using a deprecated behavior, it will be removed in version 1.25, Support for MySQL is deprecated, please migrate to PostgreSQL (called from <top (required)> at /home/jenkins/workspace/test_develop_pr_core/database/mysql/ruby/2.5/slave/fast/config/environment.rb:5) (ActiveSupport::DeprecationException)

The full message is needed, try:

# https://projects.theforeman.org/issues/27035 - message: 'You are using a deprecated behavior, it will be removed in version 1.25, Support for MySQL is deprecated, migrate to PostgreSQL'

lzap · 2019-09-09T08:47:47Z

Rebased.

tbrisker · 2019-09-09T09:08:26Z

sadly looks like that doesn't work - it is still failing on mysql with /usr/local/rvm/gems/ruby-2.5.1@test_develop_pr_core-2/gems/activesupport-5.2.1/lib/active_support/lazy_load_hooks.rb:69:in block in execute_hook': DEPRECATION WARNING: You are using a deprecated behavior, it will be removed in version 1.25, Support for MySQL is deprecated, please migrate to PostgreSQL (called from <top (required)> at /home/jenkins/workspace/test_develop_pr_core@2/database/mysql/ruby/2.5/slave/fast/config/environment.rb:5) (ActiveSupport::DeprecationException) - i'm guesing the whitelist only works during the tests themselves and not the initializers

lzap · 2019-09-09T09:35:57Z

Removed, should be good now.

lzap · 2019-09-09T10:14:36Z

Unrelated - weird failure? Cannot see it.

config/initializers/deprecations.rb

lzap · 2019-09-09T11:34:44Z

All right rebased now hopefully for the last time.

tbrisker

Thanks @lzap ! test failure unrelated

tbrisker · 2019-09-09T13:23:46Z

1.23 - 2c7aa44

theforeman-bot added Needs testing Not yet reviewed labels Jul 29, 2019

lzap requested a review from tbrisker July 29, 2019 10:23

ares reviewed Jul 29, 2019

View reviewed changes

ezr-ondrej reviewed Jul 29, 2019

View reviewed changes

ohadlevy reviewed Jul 29, 2019

View reviewed changes

config/application.rb Outdated Show resolved Hide resolved

lzap force-pushed the warning-mysql-27442 branch from a0961f5 to bd0aea4 Compare July 29, 2019 11:59

ezr-ondrej previously approved these changes Jul 31, 2019

View reviewed changes

theforeman-bot removed the Not yet reviewed label Jul 31, 2019

tbrisker reviewed Jul 31, 2019

View reviewed changes

config/initializers/deprecations.rb Outdated Show resolved Hide resolved

lzap dismissed ezr-ondrej’s stale review via 4d26e27 August 1, 2019 08:25

lzap force-pushed the warning-mysql-27442 branch from bd0aea4 to 4d26e27 Compare August 1, 2019 08:25

ezr-ondrej reviewed Aug 1, 2019

View reviewed changes

tbrisker added this to the 1.23.0 milestone Aug 21, 2019

tbrisker reviewed Sep 4, 2019

View reviewed changes

tbrisker suggested changes Sep 4, 2019

View reviewed changes

theforeman-bot added the Waiting on contributor label Sep 4, 2019

lzap force-pushed the warning-mysql-27442 branch from 4d26e27 to 61c2eee Compare September 5, 2019 11:48

theforeman-bot added Needs re-review and removed Waiting on contributor labels Sep 5, 2019

tbrisker previously approved these changes Sep 5, 2019

View reviewed changes

theforeman-bot removed the Needs re-review label Sep 5, 2019

tbrisker reviewed Sep 5, 2019

View reviewed changes

lzap dismissed tbrisker’s stale review via 53a0708 September 9, 2019 08:44

lzap force-pushed the warning-mysql-27442 branch from 61c2eee to 53a0708 Compare September 9, 2019 08:44

lzap force-pushed the warning-mysql-27442 branch from 53a0708 to 6a0cfcc Compare September 9, 2019 09:15

tbrisker suggested changes Sep 9, 2019

View reviewed changes

config/initializers/deprecations.rb Outdated Show resolved Hide resolved

config/initializers/deprecations.rb Outdated Show resolved Hide resolved

theforeman-bot added the Waiting on contributor label Sep 9, 2019

tbrisker reviewed Sep 9, 2019

View reviewed changes

config/initializers/deprecations.rb Outdated Show resolved Hide resolved

config/initializers/deprecations.rb Outdated Show resolved Hide resolved

lzap force-pushed the warning-mysql-27442 branch from 6a0cfcc to 4706356 Compare September 9, 2019 11:34

theforeman-bot added Needs re-review and removed Waiting on contributor labels Sep 9, 2019

Fixes #27442 - deprecation mysql warning

2f522f7

lzap force-pushed the warning-mysql-27442 branch from 4706356 to 2f522f7 Compare September 9, 2019 12:07

tbrisker approved these changes Sep 9, 2019

View reviewed changes

theforeman-bot removed the Needs re-review label Sep 9, 2019

tbrisker merged commit 1245c20 into theforeman:develop Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #27442 - deprecation mysql warning #6938

Fixes #27442 - deprecation mysql warning #6938

lzap commented Jul 29, 2019 •

edited

Loading

theforeman-bot commented Jul 29, 2019

lzap commented Jul 29, 2019

ares left a comment

ares Jul 29, 2019

lzap Jul 29, 2019

ezr-ondrej left a comment

ezr-ondrej Jul 29, 2019

lzap Jul 29, 2019

tbrisker commented Jul 29, 2019

ares commented Jul 29, 2019

lzap commented Jul 29, 2019

ezr-ondrej left a comment

tbrisker commented Jul 31, 2019

lzap commented Aug 1, 2019

ezr-ondrej Aug 1, 2019

lzap Aug 13, 2019

tbrisker Sep 4, 2019

tbrisker Sep 4, 2019

tbrisker left a comment

tbrisker Sep 4, 2019

lzap commented Sep 5, 2019

tbrisker left a comment

tbrisker Sep 5, 2019

mmoll Sep 5, 2019

lzap commented Sep 9, 2019

tbrisker commented Sep 9, 2019 •

edited

Loading

lzap commented Sep 9, 2019

lzap commented Sep 9, 2019

lzap commented Sep 9, 2019

tbrisker left a comment

tbrisker commented Sep 9, 2019

Fixes #27442 - deprecation mysql warning #6938

Fixes #27442 - deprecation mysql warning #6938

Conversation

lzap commented Jul 29, 2019 • edited Loading

theforeman-bot commented Jul 29, 2019

lzap commented Jul 29, 2019

ares left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ezr-ondrej left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tbrisker commented Jul 29, 2019

ares commented Jul 29, 2019

lzap commented Jul 29, 2019

ezr-ondrej left a comment

Choose a reason for hiding this comment

tbrisker commented Jul 31, 2019

lzap commented Aug 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tbrisker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lzap commented Sep 5, 2019

tbrisker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lzap commented Sep 9, 2019

tbrisker commented Sep 9, 2019 • edited Loading

lzap commented Sep 9, 2019

lzap commented Sep 9, 2019

lzap commented Sep 9, 2019

tbrisker left a comment

Choose a reason for hiding this comment

tbrisker commented Sep 9, 2019

lzap commented Jul 29, 2019 •

edited

Loading

tbrisker commented Sep 9, 2019 •

edited

Loading