Refs #28538 - Drop smart_variable left overs #7511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #28538 |
|
@tbrisker this refs an already closed issue. Do we want to cherry pick this into 2.0 or should I open a new one? |
ekohl
commented
Mar 12, 2020
| id = if smart_variable_id? | ||
| params.key?('smart_variable_id') ? params['smart_variable_id'] : params['id'] | ||
| else | ||
| params.key?('smart_class_parameter_id') ? params['smart_variable_id'] : params['id'] |
There was a problem hiding this comment.
Note this previously appeared to have a bug. Note the mismatch.
tbrisker
reviewed
Mar 12, 2020
There was a problem hiding this comment.
The previous pr was a continuation of the permission cleanup.
The full cleanup effort is being done in steps on purpose and tracked under https://projects.theforeman.org/issues/28278, to make it easier to review in parts finish rather than one giant PR removing everything.
|
Closing for now, this whole concern will be refactored/dropped in https://projects.theforeman.org/issues/28596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.