Remote addr can support several load balancers #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. 👍 from me. |
cfouant
pushed a commit
to cfouant/foreman
that referenced
this pull request
Dec 18, 2018
…man#757) * Update production.md docs to use a newer version in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortly after two load balancers were set up for our foreman installation, we noticed sometimes calls to /unattended/built were failing. This was due to this line of code in UnattendedController,
Since I thought :remote_addr was just an IP, this IP was set to one of the balancers. Of course in a system with several load balancers, some calls would fail. :remote_addr could be an array that contains several ips, but I believe that since it's a string used as a regexp, we can exploit this fact to support several load balancers. It works.