Fixes #29683 - fix params search on hg,os,domain,subnet pages #7670
Conversation
|
Issues: #29683 |
kgaikwad
force-pushed
the
29683_param_search
branch
2 times, most recently
from
bac8bde
to
d347e54
Compare
| if respond_to?(:with_taxonomy_scope) | ||
| build_query = build_query.with_taxonomy_scope | ||
| end | ||
| resource_ids = build_query.joins(parameters_relation).where(conditions).map(&:id).flatten.uniq |
There was a problem hiding this comment.
I think this might be faster:
| resource_ids = build_query.joins(parameters_relation).where(conditions).map(&:id).flatten.uniq | |
| resource_ids = build_query.joins(parameters_relation).where(conditions).distinct.pluck(:id) |
as it doesn't load all objects to memory but rather pulls the ids directly from the db
| conditions = sanitize_sql_for_conditions( | ||
| ["parameters.name = ? and parameters.searchable_value #{operator} ?", key_name, value_to_sql(operator, value)] | ||
| ) | ||
| build_query = unscoped |
There was a problem hiding this comment.
what about authorization? or would that be added anyways by the controller after the search scope?
There was a problem hiding this comment.
Yes, at controller level it uses resource_base which calls authorized if that method exists on model.
| end | ||
| resource_ids = build_query.joins(parameters_relation).where(conditions).map(&:id).flatten.uniq | ||
|
|
||
| opts = "#{table_name}.id < 0" |
There was a problem hiding this comment.
| opts = "#{table_name}.id < 0" | |
| opts = "1 < 0" |
will get the same result without checking the table index
theforeman-bot
added
Waiting on contributor
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
| end | ||
|
|
||
| def parameter_relation_symbol | ||
| case to_s |
There was a problem hiding this comment.
@tbrisker,
Here, I changed method class_name to to_s as it was failing for class_name method while running tests.
|
@kgaikwad please rebase. |
kgaikwad
force-pushed
the
29683_param_search
branch
from
f753ec7
to
18e0382
Compare
|
@shiramax, done with rebase! |
|
Any progress on this? |
kgaikwad
force-pushed
the
29683_param_search
branch
from
18e0382
to
8a94b78
Compare
|
@shiramax, it's green :) 🍏 |
No description provided.