Fixes #30563 - link to generated page instead of directory #7880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #30563 |
ares
approved these changes
Aug 5, 2020
|
(once the redmine issues preventing the merge is resolved) |
|
Thanks @mirekdlugosz and congrats on your first commit to Foreman! May many more follow 🙂 |
|
me-- for not squashing the two commits on merge :\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes on DSL documentation help page:
/dsldoc/all, which is directory. Change it to refer to/dsldoc/all.html, which is generated documentation page.I don't like how this link is language-unaware, i.e. when opened on French help page, it will refer user to English one. But all links in this paragraph behave this way.
"attached to end of some lines, making it use incorrect syntax. Remove that character, so example can be copy-pasted.Let me know if I should squash both commits, I don't think these changes require separate issue each.
CC @ares