Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #30441 - Global Registration Template API endpoint #7839

Merged
merged 6 commits into from
Jul 28, 2020
Merged

Fixes #30441 - Global Registration Template API endpoint #7839

merged 6 commits into from
Jul 28, 2020

Conversation

stejskalleos
Copy link
Contributor

PR is part of Simple & automatic host registration WF, see:

Features:

  • Global registration template
  • New API endpoint /provisioning_templates/global_registration
  • New Settings::Provisioning Default Global registration template

@theforeman-bot
Copy link
Member

Issues: #30441

@stejskalleos
Copy link
Contributor Author

@ekohl, @ares PR updated:

  • endpoint moved to /register, plus now requires create_hosts permission
  • global_registration.erb updated (& tested on Fedora, Centos, Ubuntu, Debian & RHEL)
  • Other minor changes

ares
ares requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, there's one little improvement I'd suggest, then ready to merge

app/controllers/api/v2/provisioning_templates_controller.rb Outdated Show resolved Hide resolved
@stejskalleos
Copy link
Contributor Author

Rebased & updated :not_found error message

@stejskalleos
Copy link
Contributor Author

[test katello]

ares
ares approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, waiting for katello tests

@ares
Copy link
Member

ares commented Jul 28, 2020

Katello test failures unrelated, I see the same in Katello PRs.

Thanks @stejskalleos, merging!

@ares ares merged commit bbbfdb3 into theforeman:develop Jul 28, 2020
lzap
lzap reviewed Aug 5, 2020
View reviewed changes
app/controllers/api/v2/provisioning_templates_controller.rb
if @provisioning_template
render plain: @provisioning_template.render.html_safe
else
render plain: _('Global Registration Template with name %s defined via default_global_registration_item Setting not found, please configure the existing template name first') % Setting[:default_global_registration_item], status: :not_found
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea, this could have been a shell comment, so when it gets executed it does not print errors.

@anandkumaragrawal anandkumaragrawal mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@lzap lzap lzap left review comments

@ares ares ares approved these changes

Assignees

@ares ares

Labels
Demo worthy Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stejskalleos @theforeman-bot @ares @lzap @ekohl