Fixes #31639 - Fix for syntax error when rendering Global Registration Template #8251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31639 |
ares
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Katello test failure unrelated. Fun, I missed this syntax error since I use zsh, where the script works just fine. However now when I tested on bash, it was quite straightforward to reproduce and verify this fixes the issue. I'm surprised we don't see the need to regenerate the template snapshot.
Anyway, thanks for a quick fix @stejskalleos, merging!
stefanlasiewski
pushed a commit
to stefanlasiewski/foreman
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring changes from this commit 1a144f1 cause syntax error when rendering template:
2.3-stable&sat6.9are not affected by this issue.